Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ReduceBooleanRule #2675

Merged
merged 7 commits into from Mar 10, 2019

Conversation

Projects
None yet
3 participants
@xavierLowmiller
Copy link
Contributor

commented Mar 9, 2019

Implements rule request #2583.

@SwiftLintBot

This comment has been minimized.

Copy link

commented Mar 9, 2019

7 Warnings
⚠️ This PR introduced a violation in Firefox: /Users/vsts/agent/2.148.0/work/1/s/osscheck/Firefox/Client/Frontend/Browser/TabDisplayManager.swift:158💯 warning: Reduce Boolean Violation: Use allSatisfy instead (reduce_boolean)
⚠️ This PR introduced a violation in Firefox: /Users/vsts/agent/2.148.0/work/1/s/osscheck/Firefox/Sync/BookmarkTelemetryPing.swift:8:27: warning: Reduce Boolean Violation: Use contains instead (reduce_boolean)
⚠️ This PR introduced a violation in Firefox: /Users/vsts/agent/2.148.0/work/1/s/osscheck/Firefox/SyncTelemetry/SyncTelemetryEvents.swift:59:24: warning: Reduce Boolean Violation: Use allSatisfy instead (reduce_boolean)
⚠️ This PR introduced a violation in Kickstarter: /Users/vsts/agent/2.148.0/work/1/s/osscheck/Kickstarter/Library/Navigation.swift:575:52: warning: Reduce Boolean Violation: Use contains instead (reduce_boolean)
⚠️ This PR introduced a violation in Kickstarter: /Users/vsts/agent/2.148.0/work/1/s/osscheck/Kickstarter/Library/Navigation.swift:582:42: warning: Reduce Boolean Violation: Use contains instead (reduce_boolean)
⚠️ This PR introduced a violation in Quick: /Users/vsts/agent/2.148.0/work/1/s/osscheck/Quick/Sources/Quick/World.swift:151:50: warning: Reduce Boolean Violation: Use contains instead (reduce_boolean)
⚠️ This PR introduced a violation in Quick: /Users/vsts/agent/2.148.0/work/1/s/osscheck/Quick/Sources/Quick/World.swift:220:56: warning: Reduce Boolean Violation: Use contains instead (reduce_boolean)
12 Messages
📖 Linting Aerial with this PR took 2.13s vs 1.83s on master (16% slower)
📖 Linting Alamofire with this PR took 5.75s vs 4.06s on master (41% slower)
📖 Linting Firefox with this PR took 15.68s vs 12.55s on master (24% slower)
📖 Linting Kickstarter with this PR took 22.8s vs 20.49s on master (11% slower)
📖 Linting Moya with this PR took 2.05s vs 1.82s on master (12% slower)
📖 Linting Nimble with this PR took 1.93s vs 1.82s on master (6% slower)
📖 Linting Quick with this PR took 0.59s vs 0.56s on master (5% slower)
📖 Linting Realm with this PR took 3.88s vs 3.39s on master (14% slower)
📖 Linting SourceKitten with this PR took 1.23s vs 1.15s on master (6% slower)
📖 Linting Sourcery with this PR took 4.5s vs 4.09s on master (10% slower)
📖 Linting Swift with this PR took 28.99s vs 27.4s on master (5% slower)
📖 Linting WordPress with this PR took 21.49s vs 21.31s on master (0% slower)

Generated by 🚫 Danger

@jpsim

jpsim approved these changes Mar 10, 2019

Copy link
Collaborator

left a comment

Looks good overall, I just have some small comments.

@jpsim

jpsim approved these changes Mar 10, 2019

Copy link
Collaborator

left a comment

Great work!

@jpsim jpsim merged commit 57af7f0 into realm:master Mar 10, 2019

11 checks passed

realm.SwiftLint Build #20190310.2 succeeded
Details
realm.SwiftLint (Analyze) Analyze succeeded
Details
realm.SwiftLint (CocoaPods) CocoaPods succeeded
Details
realm.SwiftLint (OSSCheck) OSSCheck succeeded
Details
realm.SwiftLint (SwiftPM xcode10) SwiftPM xcode10 succeeded
Details
realm.SwiftLint (SwiftPM xcode101) SwiftPM xcode101 succeeded
Details
realm.SwiftLint (TSan) TSan succeeded
Details
realm.SwiftLint (Xcode xcode10) Xcode xcode10 succeeded
Details
realm.SwiftLint (Xcode xcode101) Xcode xcode101 succeeded
Details
realm.SwiftLint (linux swift420) linux swift420 succeeded
Details
realm.SwiftLint (linux swift421) linux swift421 succeeded
Details

@xavierLowmiller xavierLowmiller deleted the xavierLowmiller:reduce-boolean branch Mar 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.