Add support for fetching Realm #4150
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes: - Session handles can now wait for uploads/downloads to complete - Added API to fetch a Realm and expose it to the user upon download completion - Fix Xcode project target membership for certain Sync source files - Fix a threading bug - Changed the `standaloneSession` BOOL argument some internal methods took into a `purpose` enum to more clearly distinguish between fetching Realms, opening Realms, and getting a standalone session
austinzheng
force-pushed
the
az/fetchrealm
branch
from
28d356b
to
cc1d666
Compare
|
I believe this feature is no longer desired? I am closing this PR, since even if we want it the implementation is no longer compatible with the latest code. |
|
We definitely still need a "download Realm" API that only makes the Realm available when the entire Realm file has been downloaded, and without automatically creating the file if it doesn't already exist, but I agree that we'd be better off starting fresh to implement that, and I think we're still blocked on a few lower-level sync features to expose that (protocol changes, among other things). |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needs: object server tests need to be updated.
Prereq: realm/realm-object-store#174
Replaces: https://github.com/realm/realm-cocoa-private/pull/269
Changes:
standaloneSessionBOOL argument some internal methods took into apurposeenum to more clearly distinguish between fetching Realms, opening Realms, and getting a standalone session