Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support in-memory realms #6246

Merged
merged 9 commits into from
Feb 20, 2023
Merged

Support in-memory realms #6246

merged 9 commits into from
Feb 20, 2023

Conversation

jedelbo
Copy link
Contributor

@jedelbo jedelbo commented Jan 27, 2023 •
edited
Loading

What, How & Why?

Fixes #5991

☑️ ToDos

  • 📝 Changelog update
  • 🚦 Tests (or not relevant)
  • C-API, if public C++ API changed.

@cla-bot cla-bot bot added the cla: yes label Jan 27, 2023
@jedelbo jedelbo force-pushed the je/in-memory-realm branch 3 times, most recently from 9030677 to 9577183 Compare January 30, 2023 12:58
@jedelbo jedelbo marked this pull request as ready for review January 30, 2023 13:37
finnschiermer
finnschiermer suggested changes Feb 3, 2023
View reviewed changes
Copy link
Contributor

@finnschiermer finnschiermer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice overall. A minor change is needed wrt allocation, I think. See comment.

src/realm/alloc_slab.cpp Show resolved Hide resolved
@jedelbo
Ensure 64 bit alignment on new
42fc975 
Ensures cache-line alignment
finnschiermer
finnschiermer approved these changes Feb 3, 2023
View reviewed changes
Copy link
Contributor

@finnschiermer finnschiermer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jedelbo and others added 3 commits February 3, 2023 16:04
@jedelbo
Remove 64 bit alignment again
986bb7a 
Not supported on the Apple platform we are targeting.
@finnschiermer
force alignment of slabs
96800fb
@finnschiermer
fix a warning
2fb6172
finnschiermer
finnschiermer approved these changes Feb 20, 2023
View reviewed changes
Copy link
Contributor

@finnschiermer finnschiermer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jedelbo jedelbo merged commit c6a8170 into master Feb 20, 2023
@jedelbo jedelbo deleted the je/in-memory-realm branch February 20, 2023 13:04
@kiburtse kiburtse mentioned this pull request Mar 3, 2023
Merged
3 tasks
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@finnschiermer finnschiermer finnschiermer approved these changes

Assignees

@jedelbo jedelbo

Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support creating realms in "pure" in-memory mode
2 participants
@jedelbo @finnschiermer