Expose SyncConfiguration.TrustedCAPath #1423
Conversation
| if (!string.IsNullOrEmpty(TrustedCAPath) && | ||
| !File.Exists(TrustedCAPath)) | ||
| { | ||
| throw new RealmFileNotFoundException($"File not found: {TrustedCAPath}"); |
There was a problem hiding this comment.
Is that the proper exception here? (In fact, I am not even sure why we have an exception by that name?)
There was a problem hiding this comment.
Well... the file's not there, the exception contains "FileNotFound", so I went with it :P Perhaps we can throw the system's FileNotFoundException?
There was a problem hiding this comment.
Right. Well, I can't think of any reason not to use the system one, unless we for some reason want all exceptions thrown by our SDK to be Realm*-exceptions. But that just seems silly to me. As does prefixing them with Realm in general, unless they are related to something in a realm, not just in the SDK.
There was a problem hiding this comment.
I agree - we throw a bunch of system exceptions anyway. I'll update it here, but will leave the rest of the codebase for another time ;)
Description
Fixes #1422
Also fixes a case when
client_validate_sslwasn't respected when opening a realm withGetInstanceAsync.TODO