New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Project Lombok integration? #502

Closed
arcadefire opened this Issue Oct 25, 2014 · 23 comments

Comments

Projects
None yet
@arcadefire
Copy link

arcadefire commented Oct 25, 2014

Hi to all,
first of all, great job.

I tried to make cooperate Lombok (http://projectlombok.org) and Realm.io together, but the compilation stops when the processor analyzes the annotation (@Getter/@Setter) in classes that integrate Lombok's style.

It would be nice if the two libraries could coexist. You would have a cleaner code.

@kneth kneth added the T:Enhancement label Oct 28, 2014

@kneth

This comment has been minimized.

Copy link
Contributor

kneth commented Oct 28, 2014

Thanks for bringing Lombok to our attention. We have to learn more about the project before we can say anything meaningful :-)

@bmunkholm

This comment has been minimized.

Copy link
Contributor

bmunkholm commented Oct 30, 2014

Hey Angelo,
Thanks for the nice words!

We actually did look into Lombok a while back (before Kenneth got on the
project). Lombok is a very interesting and smart hack! :-)
And thats absolutely not to say anything bad about Lombok, but the point is
merely that it does do stuff that isn't exactly conforming to anything
intended or standardised originally. And this can give some problems with
interoperability with other libraries. We only use standard annotation
processing without any hacks, so the issue would likely have to be solved
in Lombok unfortunately. That said, we would love to get rid of the
getters/setters at some point if possible. So solving this, might need a
Lombok expert :-)
If you pursue this, I would be very happy to hear about it!

Let us know if there is anything else we can help with!
Cheers
//Brian

On Tue, Oct 28, 2014 at 10:00 AM, Kenneth Geisshirt <
notifications@github.com> wrote:

Thanks for bringing Lombok to our attention. We have to learn more about
the project before we can say anything meaningful :-)


Reply to this email directly or view it on GitHub
#502 (comment).

@somghosh

This comment has been minimized.

Copy link

somghosh commented Dec 24, 2014

I would support this as well - now the Realm processing does not work because it does not see the getter/setter by Lombok

@sirvon

This comment has been minimized.

Copy link

sirvon commented Jan 21, 2015

+1

2 similar comments
@andrewazores

This comment has been minimized.

Copy link

andrewazores commented Mar 2, 2015

+1

@ScottPierce

This comment has been minimized.

Copy link

ScottPierce commented Apr 13, 2015

+1

@cmelchior cmelchior added P2 and removed P2 labels Apr 15, 2015

@sxua

This comment has been minimized.

Copy link

sxua commented May 25, 2015

Summoning @rzwitserloot in this thread 😃

@mandrachek

This comment has been minimized.

Copy link

mandrachek commented Jun 1, 2015

+1

@b52

This comment has been minimized.

Copy link

b52 commented Jun 11, 2015

What's the state on this one? Lombok solves a real issues you forces us to bear.

@skptl

This comment has been minimized.

Copy link

skptl commented Jul 22, 2015

Any updates on the issue?

@emanuelez

This comment has been minimized.

Copy link
Contributor

emanuelez commented Jul 22, 2015

No update on this yet, but we're working on a way to use Realm by manipulating fields instead of accessors. After that is complete we will re-evaluate Lombok support.

@rzwitserloot

This comment has been minimized.

Copy link

rzwitserloot commented Jul 27, 2015

Lombok (tries to) execute before other APs so that other APs get to see the changes. If that is not happening, possibly all you really need to do is re-order your classpath. If that still doesn't work, we'll have to investigate.

@hamen

This comment has been minimized.

Copy link

hamen commented Aug 13, 2015

+1

1 similar comment
@mihirjoshi21

This comment has been minimized.

Copy link

mihirjoshi21 commented Sep 17, 2015

+1

@skhaz

This comment has been minimized.

Copy link

skhaz commented Dec 1, 2015

bump

@cyberrob

This comment has been minimized.

Copy link

cyberrob commented Jan 29, 2016

Really looking forward to this!

@kneth

This comment has been minimized.

Copy link
Contributor

kneth commented Jan 29, 2016

Just in case you are wondering if we are getting close, you can take a look at #2196.

@tuhochi

This comment has been minimized.

Copy link

tuhochi commented Feb 25, 2016

+1

@orubel

This comment has been minimized.

Copy link

orubel commented Jun 22, 2016

+1

@bmunkholm

This comment has been minimized.

Copy link
Contributor

bmunkholm commented Jun 29, 2016

@orubel What are you missing? This is already supported.

@mariusz-k

This comment has been minimized.

Copy link

mariusz-k commented Jul 8, 2016

What type of annotation from Lombok are available ? I try to use @builder in class and compilation of project crash ?

@Allsimon

This comment has been minimized.

Copy link

Allsimon commented Jul 8, 2016

Strange, this is working with 1.1.0

@Data
@Builder
@Wither
@NoArgsConstructor
@AllArgsConstructor
@EqualsAndHashCode(of = "objectId", callSuper = false)
public class RealmUserPost extends RealmObject{
@mariusz-k

This comment has been minimized.

Copy link

mariusz-k commented Jul 8, 2016

Ok after add every thing start work. Thank ! :

@Builder
@NoArgsConstructor
@AllArgsConstructor
@EqualsAndHashCode(callSuper = false)

@realm realm locked and limited conversation to collaborators Jul 14, 2016

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.