From a3e796270164eb6805684c1677651f86aeb7b938 Mon Sep 17 00:00:00 2001 From: LJ <81748770+elle-j@users.noreply.github.com> Date: Fri, 20 Oct 2023 13:51:03 +0200 Subject: [PATCH 1/3] Update postinstall script since bindgen is in Core master. --- package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package.json b/package.json index 82d6d22db85..c2f2f0cb72b 100644 --- a/package.json +++ b/package.json @@ -11,7 +11,7 @@ "lint:fix": "wireit", "lint:cpp": "find src packages/realm/bindgen/src -name '*.cpp' -or -name '*.h' -or -name '*.hpp' | xargs clang-format --dry-run --Werror", "lint:cpp:fix": "find src packages/realm/bindgen/src -name '*.cpp' -or -name '*.h' -or -name '*.hpp' | xargs clang-format -i", - "postinstall": "git submodule update --init --recursive" + "postinstall": "git submodule update --init --recursive && npm install --prefix ./packages/realm/bindgen/vendor/realm-core" }, "wireit": { "build": { From 5e0f7ade03070d8e00c530a6cdcb438572e90518 Mon Sep 17 00:00:00 2001 From: LJ <81748770+elle-j@users.noreply.github.com> Date: Fri, 20 Oct 2023 16:06:00 +0200 Subject: [PATCH 2/3] Remove postinstall script. --- package.json | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/package.json b/package.json index c2f2f0cb72b..7170d351fb7 100644 --- a/package.json +++ b/package.json @@ -10,8 +10,7 @@ "lint": "wireit", "lint:fix": "wireit", "lint:cpp": "find src packages/realm/bindgen/src -name '*.cpp' -or -name '*.h' -or -name '*.hpp' | xargs clang-format --dry-run --Werror", - "lint:cpp:fix": "find src packages/realm/bindgen/src -name '*.cpp' -or -name '*.h' -or -name '*.hpp' | xargs clang-format -i", - "postinstall": "git submodule update --init --recursive && npm install --prefix ./packages/realm/bindgen/vendor/realm-core" + "lint:cpp:fix": "find src packages/realm/bindgen/src -name '*.cpp' -or -name '*.h' -or -name '*.hpp' | xargs clang-format -i" }, "wireit": { "build": { From 021bfe9d9629caeaaefff545b7f2b9e76b3ad09e Mon Sep 17 00:00:00 2001 From: LJ <81748770+elle-j@users.noreply.github.com> Date: Wed, 25 Oct 2023 12:19:21 +0200 Subject: [PATCH 3/3] Add 'npm install' to 'building.md'. --- contrib/building.md | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/contrib/building.md b/contrib/building.md index b42ee51adcc..0cc80ffcf01 100644 --- a/contrib/building.md +++ b/contrib/building.md @@ -145,12 +145,13 @@ export PATH=/libexec:$PATH ## Cloning the repository -To clone the RealmJS repository and install git submodules: +To clone the RealmJS repository and install git submodules and dependencies. ```sh git clone https://github.com/realm/realm-js.git cd realm-js git submodule update --init --recursive +npm install ``` In order to improve the accuracy of `git blame` locally by ignoring commits in which the code was reformatted by an automated tool, run: `git config blame.ignoreRevsFile .gitignore-revs` from inside the repository.