From 3adbb7487d5ea6c13cd9cec8af958bd27cd9a049 Mon Sep 17 00:00:00 2001 From: Andrew Meyer Date: Wed, 23 Aug 2023 10:01:21 +0200 Subject: [PATCH] Apply suggestions from code review Co-authored-by: LJ <81748770+elle-j@users.noreply.github.com> --- packages/realm-react/CHANGELOG.md | 2 +- packages/realm-react/README.md | 2 +- packages/realm-react/src/__tests__/RealmProvider.test.tsx | 1 - 3 files changed, 2 insertions(+), 3 deletions(-) diff --git a/packages/realm-react/CHANGELOG.md b/packages/realm-react/CHANGELOG.md index c020ce3505..e131f56330 100644 --- a/packages/realm-react/CHANGELOG.md +++ b/packages/realm-react/CHANGELOG.md @@ -4,7 +4,7 @@ * None ### Enhancements -* Add flag to keep realm open on unmount of RealmProvider. ([#6023](https://github.com/realm/realm-js/issues/6023)) +* Add flag to keep realm open on unmount of `RealmProvider`. ([#6023](https://github.com/realm/realm-js/issues/6023)) ### Fixed * ([#????](https://github.com/realm/realm-js/issues/????), since v?.?.?) diff --git a/packages/realm-react/README.md b/packages/realm-react/README.md index 81a7d84335..f1ab2732c5 100644 --- a/packages/realm-react/README.md +++ b/packages/realm-react/README.md @@ -235,7 +235,7 @@ const AppWrapper = () => { } ``` -It may also be necessary to render multiple `RealmProvider`s of the same Realm in an app. In this case, the flag `closeOnUnmount` can be set to `false`` to prevent both Realm instances from closing when one has been removed from the component tree. +It may also be necessary to render multiple `RealmProvider`s of the same Realm in an app. In this case, the flag `closeOnUnmount` can be set to `false`` to prevent both Realm instances from closing when one has been removed from the component tree. This is set to `true` by default. ```tsx diff --git a/packages/realm-react/src/__tests__/RealmProvider.test.tsx b/packages/realm-react/src/__tests__/RealmProvider.test.tsx index 5f7321f6eb..7cdf9145a6 100644 --- a/packages/realm-react/src/__tests__/RealmProvider.test.tsx +++ b/packages/realm-react/src/__tests__/RealmProvider.test.tsx @@ -75,7 +75,6 @@ describe("RealmProvider", () => { const { result, unmount } = renderHook(() => useRealm(), { wrapper }); await waitFor(() => expect(result.current).not.toBe(null)); const realm = result.current; - expect(realm).not.toBe(null); expect(realm.schema[0].name).toBe("dog"); unmount(); expect(realm.isClosed).toBe(false);