[bindgen] Adding Browser/WASM target to bindgen #5525
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kraenhansen
reviewed
Mar 3, 2023
| @@ -25,12 +25,15 @@ export function generate({ spec: rawSpec, file }: TemplateContext): void { | |||
| const spec = doJsPasses(bindModel(rawSpec)); | |||
| const reactLines = []; | |||
| const nodeLines = []; | |||
| function both(content: string) { | |||
| const browserLines = []; | |||
There was a problem hiding this comment.
I don't like this pattern and the direction this is going. This file should be refactored into multiple files with separated concerns (one per platform) before this PR lands to separate node from react-native. @RedBeard0531 we've talked about this before and I believe you had a plan for it?
nhachicha
changed the title
nhachicha
force-pushed
the
nh/wasm/rebased_bindgen
branch
from
af9775c
to
5fb1517
Compare
Breaks the other bindings.
- Using positional argument instead of JS array when passing value to C++
nhachicha
force-pushed
the
nh/wasm/rebased_bindgen
branch
2 times, most recently
from
8ee86e5
to
6dd5018
Compare
nhachicha
force-pushed
the
nh/wasm/rebased_bindgen
branch
from
6dd5018
to
a398880
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebase of #5497 on top of current
bindgenbranch