-
Notifications
You must be signed in to change notification settings - Fork 564
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[bindgen] Adding Browser/WASM target to bindgen #5525
base: main
Are you sure you want to change the base?
Conversation
@@ -25,12 +25,15 @@ export function generate({ spec: rawSpec, file }: TemplateContext): void { | |||
const spec = doJsPasses(bindModel(rawSpec)); | |||
const reactLines = []; | |||
const nodeLines = []; | |||
function both(content: string) { | |||
const browserLines = []; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't like this pattern and the direction this is going. This file should be refactored into multiple files with separated concerns (one per platform) before this PR lands to separate node from react-native. @RedBeard0531 we've talked about this before and I believe you had a plan for it?
af9775c
to
5fb1517
Compare
Breaks the other bindings.
- Using positional argument instead of JS array when passing value to C++
8ee86e5
to
6dd5018
Compare
6dd5018
to
a398880
Compare
Rebase of #5497 on top of current
bindgen
branch