New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TSlint updated and errors fixed #1000

Merged
merged 3 commits into from Nov 14, 2018

Conversation

Projects
None yet
3 participants
@kraenhansen
Contributor

kraenhansen commented Nov 14, 2018

No description provided.

kraenhansen added some commits Nov 14, 2018

@kraenhansen kraenhansen self-assigned this Nov 14, 2018

@kraenhansen kraenhansen merged commit accc3ee into master Nov 14, 2018

1 check was pending

continuous-integration/jenkins/pr-head This commit is being built
Details

@kraenhansen kraenhansen deleted the kh/tslint-fixed branch Nov 14, 2018

? 'int?'
: Util.isDouble(value) ? 'double?' : 'string?';
? 'int?'
: Util.isDouble(value)

This comment has been minimized.

@nirinchev

This comment has been minimized.

@kraenhansen

kraenhansen Nov 15, 2018

Contributor

I didn't write this - I just ran the linter 😆

This comment has been minimized.

@nirinchev

nirinchev Nov 15, 2018

Member

See - even the linter has no idea what to do with the conditional 😂 I'm telling you, we should use plain old if-s 🙄

This comment has been minimized.

@kraenhansen

kraenhansen Nov 19, 2018

Contributor

Agree - for this a plain old if would probably be the best choice :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment