New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved AddColumnControl up from the HeaderGrid into the Table #1008

Merged
merged 4 commits into from Nov 16, 2018

Conversation

Projects
None yet
2 participants
@kraenhansen
Contributor

kraenhansen commented Nov 16, 2018

This fixes #1007 by transforming the AddColumn column into a button floating on-top-of the table header.

When the table has a few properties

The button to add a column sticks to the table properties, so it's not alone all the way to the right.

skaermbillede 2018-11-16 kl 09 42 34

When the table has a lot of properties

If the user is not scrolled all the way to the right, the button overlays the header.

skaermbillede 2018-11-16 kl 09 42 45

If the user is scrolled all the way to the right, the button hides itself to allow the user to see the entire last column without obstructions.

skaermbillede 2018-11-16 kl 09 42 51

@kraenhansen kraenhansen added the T:Bug label Nov 16, 2018

@kraenhansen kraenhansen self-assigned this Nov 16, 2018

@realm-probot realm-probot bot removed the Thinking Robot label Nov 16, 2018

kraenhansen added some commits Nov 16, 2018

@kraenhansen kraenhansen merged commit 913092f into master Nov 16, 2018

1 check passed

continuous-integration/jenkins/pr-head This commit looks good
Details

@kraenhansen kraenhansen deleted the kh/add-property-fixed branch Nov 16, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment