New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleaning up the package.json (using semver instead of compare-versions) #1010

Merged
merged 3 commits into from Nov 16, 2018

Conversation

Projects
None yet
2 participants
@kraenhansen
Contributor

kraenhansen commented Nov 16, 2018

The package had two dependencies to perform comparison of semantic versions, this PR merges the two, by using the most popular option.

@kraenhansen kraenhansen self-assigned this Nov 16, 2018

@realm-probot realm-probot bot removed the Thinking Robot label Nov 16, 2018

@kraenhansen kraenhansen requested a review from nirinchev Nov 16, 2018

@kraenhansen kraenhansen merged commit ce76045 into master Nov 16, 2018

1 check passed

continuous-integration/jenkins/pr-head This commit looks good
Details

@kraenhansen kraenhansen deleted the kh/package-json-cleanup branch Nov 16, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment