New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reading Realm sizes from a /__metrics Realm #1028

Merged
merged 30 commits into from Dec 18, 2018

Conversation

Projects
None yet
2 participants
@kraenhansen
Copy link
Contributor

kraenhansen commented Dec 3, 2018

Together with realm/realm-object-server-private#1361 this fixes #938.

It also fixes #917, showing the connection state for the and #396 for the ServerAdministration window.

It also adds usage of the react-realm-context library to the ServerAdministration window.

I've added a note to the release notes on the dependency on a new version of the server, but since this is fixing a broken feature I don't consider that a breaking change.

Table of Realms with a single size column

Note how both data (state) and file size is shown in a single column. Hovering either reveals a tooltip so users can determine which is which. Also note the green connection state indicator in the top right corner of the window.

skaermbillede 2018-12-17 kl 14 15 36

Selecting a Realm with a size

Note both sizes on the same line and the "Recalculate size" button was moved to the controls section of the sidebar.

skaermbillede 2018-12-17 kl 14 15 40

Selecting a Realm without a size

skaermbillede 2018-12-17 kl 14 15 44

@kraenhansen kraenhansen added the T:Bug label Dec 3, 2018

@kraenhansen kraenhansen self-assigned this Dec 3, 2018

@kraenhansen kraenhansen force-pushed the kh/realm-size-realm branch from 6d8c262 to 624a603 Dec 17, 2018

@kraenhansen

This comment has been minimized.

Copy link
Contributor Author

kraenhansen commented Dec 17, 2018

I updated the screenshots to match the current state of this PR, holding back on releasing this until I'm sure the Cloud instances run with state size reporting turned on.

@kraenhansen kraenhansen merged commit 83fe4bf into master Dec 18, 2018

1 check passed

continuous-integration/jenkins/pr-head This commit looks good
Details

@kraenhansen kraenhansen deleted the kh/realm-size-realm branch Dec 18, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment