Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better error dialogs #1061

Merged
merged 3 commits into from Jan 2, 2019
Merged

Better error dialogs #1061

merged 3 commits into from Jan 2, 2019

Conversation

@kraenhansen
Copy link
Member

@kraenhansen kraenhansen commented Jan 2, 2019

This improves the error dialog to provide a clear separation between failed intent and message from the exception thrown. It should also unify more user events on Sentry as these will now only have a message consisting of the failed intent.

Before

skaermbillede 2019-01-02 kl 09 56 05

After

skaermbillede 2019-01-02 kl 09 54 28

Disregard the icon being the generic Electron icon.

@kraenhansen kraenhansen self-assigned this Jan 2, 2019
@kraenhansen kraenhansen merged commit 53e871e into master Jan 2, 2019
1 check passed
@nirinchev nirinchev deleted the kh/better-error-dialog branch Mar 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants