Read-Only partial realms #1062
Merged
Read-Only partial realms #1062
Conversation
bmunkholm
reviewed
Jan 2, 2019
| await main.showRealmBrowser({ realm }); | ||
| } | ||
| } else { | ||
| throw new Error("Couldn't find the Realm in the /__admin Realm"); |
perhaps mention which realm? Or is that obvious from the context?
You just clicked open on a specific Realm, so yeah - I would say so.
bmunkholm
reviewed
Jan 2, 2019
| electron.remote.getCurrentWindow(), | ||
| { | ||
| message: | ||
| 'You are opening a partial Realm created for a specific device. To ensure other divices do not write to this it will be opened in read-only mode.', |
divices -> devices.
But perhaps the wording could be better around "To ensure other divices do not write to this".
Perhaps "client" is a better term than "device"?
Perhaps just:
"You are opening a partial Realm created for a specific client. You can only view the content in read-only mode."
|
@kraenhansen Notice I added some comments. |
bmunkholm
reviewed
Jan 2, 2019
| @@ -11,3 +11,4 @@ | |||
| ## Internals | |||
| - Fixed the Dockerfile used when testing PRs. ([#1057](https://github.com/realm/realm-studio/pull/1057)) | |||
| - Removing all existing and future unused locals. ([#1058](https://github.com/realm/realm-studio/pull/1058)) | |||
| - Ensuring users open partial Realms in a read-only mode. ([#1062](https://github.com/realm/realm-studio/pull/1062)) | |||
This has a public effect so shouldn't just be under "internals"?
You're right - moving this to the bugfix section.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
This fixes #1031 by adding a warning when opening partial Realms from the server and opening the browser in a "Read-Only" mode where no classes, properties nor objects can be created, the permissions sidebar and editing data is disabled. If for some reason some UI is not disabled correctly it also monkey-patches the
writemethod of the Realm to ensure nothing writes to it.Dialog
Note how the user can choose to not show this warning again.
The browser opening a partial Realm in read-only mode
Note the hint in the left sidebar, telling the user that it's: Opened as "Read Only"
The text was updated successfully, but these errors were encountered: