Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upRead-Only partial realms #1062
Conversation
kraenhansen
added some commits
Jan 2, 2019
kraenhansen
added
the
T:Internal
label
Jan 2, 2019
kraenhansen
self-assigned this
Jan 2, 2019
realm-ci
added
the
Thinking Robot
label
Jan 2, 2019
realm-probot
bot
removed
the
Thinking Robot
label
Jan 2, 2019
kraenhansen
merged commit 269e91d
into
master
Jan 2, 2019
1 check passed
continuous-integration/jenkins/pr-head
This commit looks good
Details
kraenhansen
deleted the
kh/read-only-partial-realms
branch
Jan 2, 2019
bmunkholm
reviewed
Jan 2, 2019
| await main.showRealmBrowser({ realm }); | ||
| } | ||
| } else { | ||
| throw new Error("Couldn't find the Realm in the /__admin Realm"); |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
kraenhansen
Jan 2, 2019
Author
Contributor
You just clicked open on a specific Realm, so yeah - I would say so.
bmunkholm
reviewed
Jan 2, 2019
| electron.remote.getCurrentWindow(), | ||
| { | ||
| message: | ||
| 'You are opening a partial Realm created for a specific device. To ensure other divices do not write to this it will be opened in read-only mode.', |
This comment has been minimized.
This comment has been minimized.
bmunkholm
Jan 2, 2019
Contributor
divices -> devices.
But perhaps the wording could be better around "To ensure other divices do not write to this".
Perhaps "client" is a better term than "device"?
Perhaps just:
"You are opening a partial Realm created for a specific client. You can only view the content in read-only mode."
This comment has been minimized.
This comment has been minimized.
|
@kraenhansen Notice I added some comments. |
bmunkholm
reviewed
Jan 2, 2019
| @@ -11,3 +11,4 @@ | |||
| ## Internals | |||
| - Fixed the Dockerfile used when testing PRs. ([#1057](https://github.com/realm/realm-studio/pull/1057)) | |||
| - Removing all existing and future unused locals. ([#1058](https://github.com/realm/realm-studio/pull/1058)) | |||
| - Ensuring users open partial Realms in a read-only mode. ([#1062](https://github.com/realm/realm-studio/pull/1062)) | |||
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
kraenhansen
referenced this pull request
Jan 2, 2019
Merged
Updated wording when opening a partial Realm #1063
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
kraenhansen commentedJan 2, 2019
This fixes #1031 by adding a warning when opening partial Realms from the server and opening the browser in a "Read-Only" mode where no classes, properties nor objects can be created, the permissions sidebar and editing data is disabled. If for some reason some UI is not disabled correctly it also monkey-patches the
writemethod of the Realm to ensure nothing writes to it.Dialog
Note how the user can choose to not show this warning again.
The browser opening a partial Realm in read-only mode
Note the hint in the left sidebar, telling the user that it's: Opened as "Read Only"