Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow more powerful queries for Realms/Users tables #1147

Merged
merged 3 commits into from Jun 4, 2019

Conversation

Projects
None yet
2 participants
@nirinchev
Copy link
Member

commented May 3, 2019

Fixes #1146

Some screens:

Screen Shot 2019-05-03 at 17 55 17

Screen Shot 2019-05-03 at 17 55 34

Screen Shot 2019-05-03 at 17 56 00

@nirinchev nirinchev requested a review from kraenhansen May 3, 2019

@nirinchev nirinchev self-assigned this May 3, 2019

@@ -81,8 +83,9 @@ export const RealmsTable = ({
onElementDoubleClick={onRealmOpened}
onElementsDeselection={onRealmsDeselection}
onSearchStringChange={onSearchStringChange}
searchPlaceholder="Search Realms"
searchPlaceholder="Search Realms (start with ! to write a verbatim realm-js query)"

This comment has been minimized.

Copy link
@kraenhansen

kraenhansen May 7, 2019

Contributor

I believe this placeholder is a bit (too) cryptic - perhaps we could move this explanation, with a couple of examples to a tooltip which is shown when pressing "?" button at the end of the input field or perhaps a placeholder in the table when the query doesn't return any results?

Show resolved Hide resolved src/ui/ServerAdministration/utils.tsx Outdated

nirinchev added some commits Jun 3, 2019

Addressed feedback

@nirinchev nirinchev merged commit 7e91389 into master Jun 4, 2019

1 check passed

continuous-integration/jenkins/pr-head This commit looks good
Details

@nirinchev nirinchev deleted the ni/more-powerful-queries branch Jun 4, 2019

"husky": {
"hooks": {
"pre-commit": "lint-staged"
}

This comment has been minimized.

Copy link
@kraenhansen

kraenhansen Jun 8, 2019

Contributor

Not a big fan of this change @nirinchev.
Having a pre-commit hook makes it easier to help contributors remember to run linting.

If you think this was really necessary, I think it should have been a separate PR to make it easier to revert in the future.

This comment has been minimized.

Copy link
@nirinchev

nirinchev Jun 8, 2019

Author Member

I couldn't commit due to an error that I showed you some time ago. While I agree it could have been done in a separate PR, it didn't seem worth the effort. I'll create an issue to track enabling it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.