Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add progress labels when opening a Realm #1148

Merged
merged 2 commits into from Jun 4, 2019

Conversation

Projects
None yet
4 participants
@nirinchev
Copy link
Member

commented Jun 4, 2019

Adds labels to the Realm download bar:

Screen Shot 2019-06-04 at 13 47 07

@nirinchev nirinchev self-assigned this Jun 4, 2019

@realm-probot realm-probot bot removed the Thinking Robot label Jun 4, 2019

@nirinchev nirinchev requested a review from cmelchior Jun 4, 2019

@nirinchev nirinchev merged commit f3fee33 into master Jun 4, 2019

1 check passed

continuous-integration/jenkins/pr-head This commit looks good
Details

@nirinchev nirinchev deleted the ni/progress branch Jun 4, 2019

@@ -75,7 +76,10 @@ export const LoadingOverlay = ({
className="LoadingOverlay__Progress"
value={progress.transferred}
max={progress.transferable}
/>
>
{// tslint:disable-next-line: prettier

This comment has been minimized.

Copy link
@kraenhansen

kraenhansen Jun 8, 2019

Contributor

@nirinchev: You could move this to a helping function which takes progress as an argument, instead of disabling prettier. I think it's the only place in the codebase that prettier gets disabled ... for no good reason in my opinion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.