Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Java & Kotlin schema export fixed #1181

Merged
merged 2 commits into from Sep 27, 2019
Merged

Conversation

@kraenhansen
Copy link
Member

kraenhansen commented Sep 27, 2019

This fixes #1163 by ensuring that the @Required annotation is only used on lists of primitives when exporting schemas to either Java or Kotlin.

@kraenhansen kraenhansen added the T-Bug label Sep 27, 2019
@kraenhansen kraenhansen requested a review from cmelchior Sep 27, 2019
@kraenhansen kraenhansen self-assigned this Sep 27, 2019
@realm-probot realm-probot bot removed the Thinking-Robot label Sep 27, 2019
@kraenhansen kraenhansen merged commit db1af62 into master Sep 27, 2019
1 check passed
1 check passed
continuous-integration/jenkins/pr-head This commit looks good
Details
@kraenhansen kraenhansen deleted the kh/java-schema-export-fixed branch Sep 27, 2019
@cmelchior

This comment has been minimized.

Copy link
Collaborator

cmelchior commented Sep 27, 2019

Seems fine 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants
You can’t perform that action at this time.