New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide path-level permissions block for Query-based Realms #989

Merged
merged 1 commit into from Nov 12, 2018

Conversation

Projects
None yet
2 participants
@cmelchior
Collaborator

cmelchior commented Nov 12, 2018

Previous behavior: The User permissions block was shown for all Realm types. This was confusing as the Path-level permissions are not applicable to Query-based Realms.

New behavior: Hide User Permissions for Reference and Partial type Realms. Also push the buttons to the bottom of the screen, always.

We might want to consider showing the Realm-level permissions for Partial Realms in this block, but doing that is outside the scope of this PR.


image

image

image

image

@cmelchior cmelchior requested a review from kraenhansen Nov 12, 2018

@cmelchior cmelchior self-assigned this Nov 12, 2018

@kraenhansen

Looking good.

Perhaps it would make sense to add a note which making it obvious that user permissions are managed from within the Realm? I don't think that should hold this change back.

@cmelchior cmelchior merged commit 80ce391 into master Nov 12, 2018

1 check passed

continuous-integration/jenkins/pr-head This commit looks good
Details

@cmelchior cmelchior deleted the cm/hide-path-level-permissions branch Nov 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment