Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce the default window height as a lower limit when restoring heights #991

merged 1 commit into from Nov 13, 2018
Changes from all commits
File filter...
Filter file types
Jump to…
Jump to file or symbol
Failed to load files and symbols.


Just for now

Enforce the default window height as a lower limit when restoring hei…

  • Loading branch information...
kraenhansen committed Nov 13, 2018
commit 065c8f6f7e0fc4a8191f981d5f26ed2598412cb3
@@ -79,6 +79,12 @@ export class WindowManager {
const defaultWindowOptions = getWindowOptions(options);
// Get the window options that are saved for this type of window
const savedWindowOptions = this.getWindowOptions(options.type);
// Ensure the saved window options don't get out of control
// @see
savedWindowOptions.height = Math.max(
defaultWindowOptions.height || 600,
savedWindowOptions.height || 0,
// Combine these with general default options
const combinedWindowOptions: IWindowConstructorOptions = {
// Starting with the default options
ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.