[RLMResults][Results] Add handover to a target dispatch queue #2300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| RLMRealm *createWithRealmCreation(RealmCreation realmCreation, SharedGroup::VersionID version) { | ||
| try { | ||
| NSError *realmCreationError = nil; | ||
| RLMRealm *realm = [RLMRealm realmWithPath:realmCreation.path key:realmCreation.key readOnly:realmCreation.readOnly inMemory:realmCreation.inMemory dynamic:realmCreation.dynamic schema:realmCreation.schema error:&realmCreationError]; |
There was a problem hiding this comment.
we probably want to pass nil for the error pointer here so that we throw if the realm can't be created.
There was a problem hiding this comment.
No, we specifically dont want to throw since we're on a background thread
|
The one thing that we're not doing here is error handling. I think it's worth the ability to pass in an NSError pointer in the public API and using |
| @param queue The dispatch queue onto which the results should be delivered. | ||
| @param block The block to be called on the given `queue` with the queue-local copy of the results. | ||
| */ | ||
| - (void)deliverOnQueue:(dispatch_queue_t)queue block:(void (^)( RLMResults RLM_GENERIC_RETURN * __nullable , NSError * __nullable ))block; |
There was a problem hiding this comment.
Maybe just deliverOn:?
There's some extra whitespace here.
|
Closing this because it's probably the wrong approach and a gross misuse of the Core APIs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1097.