Bug: SWS/IX: Import m3u/pls playlist - crash when cancelling file loading dialog

[nofishonfriday]

(click image for bigger version)

[cfillion]

It was also leaking the filename buffer when not cancelling...

[nofishonfriday]

Hah, you were a tad faster. 🔫 I was just about to open my fix PR when I noticed yours (missed the leaking though).,
Thanks.

edit:
Scratch below, I think I misunderstood the functionality of the 'No' option.

===

While at it, I found another minor quirk, when clicking 'No' in the 'Cannot find some files. Create items anyway?' dialog it creates the items anyway.

sws/IX/PlaylistImport.cpp

Line 267 in 400c3c1

case 7 : // No

should be 'return' instead of 'break' in line 268 I think.
Would you add that too to your PR ?

[cfillion]

Oh sorry! I wasn't sure whether you wanted to fix it...

Maybe the message box should instead say "The following files cannot be found. Create items for them anyway?" to be clearer.

[nofishonfriday]

No problem, doesn't matter to me who fixes something in the end. :)

Maybe the message should instead say "The following files cannot be found. Create items for them anyway?" to be clearer.

That's what I thought it should do, but here I import a playlist where files are not found, when I click 'No' it still creates the (offline) items, that's what confuses me.

[cfillion]

Looks like another bug to me! I'm guessing PCM_Source_CreateFromFile used to return NULL at the time this feature was written when the file didn't exist.

[nofishonfriday]

This seems to fix I think:
L 296:
if(pSrc && pSrc->GetSampleRate() > 0 || includeMissing)

edit:
Nevermind, just saw that you pushed a fix already, thanks.