Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Action "SWS: Quantize item's start to grid (keep length)" crashes Reaper when selecting multiple audio items and grid spacing is set to "frame" #1057

Closed
s9menine opened this issue Nov 12, 2018 · 4 comments

Comments

@s9menine
Copy link

@s9menine s9menine commented Nov 12, 2018

Reaper v5.961/x64, SWS v2.9.7, Windows 7 64-bit. Report files found in Windows Event Viewer attached
reaper quantize crash.zip

@cfillion
Copy link
Collaborator

@cfillion cfillion commented Nov 13, 2018

Please try this build and send a dump file created while it's frozen (using the task manager).

@s9menine
Copy link
Author

@s9menine s9menine commented Nov 13, 2018

Here it is, too big for Github so I uploaded to GDrive https://drive.google.com/file/d/1bxwO1GbcwG9zWkeiFsUOwB-suear0t29/view?usp=sharing

@cfillion
Copy link
Collaborator

@cfillion cfillion commented Nov 14, 2018

Thanks! I found two bugs leading to that action freezing when the grid line spacing is set to frames. Should be fixed in this build: https://cfillion.ca/files/sws/fix-quantize-time-frame/reaper_sws64.dll.

What were your project start time and frame rate set to in the project settings?

cfillion added a commit to cfillion/sws that referenced this issue Nov 14, 2018
For example, with a framerate of 1: GetPrevGridDivision(4) would give 4 instead of 3. (GetNextGridDivision(4) would correctly give 5.)

Fixes reaper-oss#1057
@s9menine
Copy link
Author

@s9menine s9menine commented Nov 14, 2018

The new build works, thanks!

The crash happened across multiple projects, but my project start time is usually negative (project start measure at 0, and set 0:00 to measure 1), and frame rate is usually 30Hz.

@swstim swstim closed this in f5b4b72 Feb 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants