Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Loudness: erratic results with short items and item volume not 0.0 #1074

Closed
nofishonfriday opened this issue Dec 10, 2018 · 0 comments
Closed
Assignees

Comments

@nofishonfriday
Copy link
Collaborator

@nofishonfriday nofishonfriday commented Dec 10, 2018

Reminder for
https://forum.cockos.com/showthread.php?p=2067567#post2067567

@nofishonfriday nofishonfriday changed the title Loudness: erratic results with short items and item volume not 0.0 Bug: Loudness: erratic results with short items and item volume not 0.0 Dec 10, 2018
@nofishonfriday nofishonfriday self-assigned this Dec 12, 2018
nofishonfriday added a commit to nofishonfriday/sws that referenced this issue Dec 12, 2018
 - Revert (mistakenly) changing integrated Loudness relative gate threshold from -10.0 LU to -20.0 LU in SWS v2.9.8
 - Fix getting project sample rate
- Don't apply item vol. and pan/vol. envelope correction beyond actual audio data (fixes reaper-oss#1074)
- Fix item Loudness analysis if take contains volume envelope (closes reaper-oss#957)
nofishonfriday added a commit to nofishonfriday/sws that referenced this issue Dec 12, 2018
 - Revert (mistakenly) changing integrated Loudness relative gate threshold from -10.0 LU to -20.0 LU in SWS v2.9.8
 - Fix getting project sample rate
- Don't apply item vol. and pan/vol. envelope correction beyond actual audio data (fixes reaper-oss#1074)
- Fix item Loudness analysis if take contains volume envelope and item pos. not 0.0 (closes reaper-oss#957)
@swstim swstim closed this in 40f494c Feb 6, 2019
nofishonfriday added a commit to nofishonfriday/sws that referenced this issue Mar 19, 2019
…-init buffer)

(refix reaper-oss#1074)
+ add missing check normal vs. high precision mode
nofishonfriday added a commit to nofishonfriday/sws that referenced this issue Aug 17, 2019
…com/nofishonfriday/sws into sws-2019-08, PR reaper-oss#1122

* 'loudness-high-precision-mode-tweaks' of https://github.com/nofishonfriday/sws:
  Loudness: fix erratic results with items shorter than 3 seconds (zero-init buffer) (refix reaper-oss#1074) + add missing check normal vs. high precision mode
  Loudness: high precision mode tweaks: - fix potential crash when analyzing items shorter than 3 seconds - disable creating graph, disable go to max. short-term / momentary - ReaScript: disable 'high precision' mode for NF_AnalyzeTakeLoudness2() + SnM_Notes.cpp: fix indention

# Conflicts:
#	whatsnew.txt
nofishonfriday added a commit to nofishonfriday/sws that referenced this issue Sep 12, 2019
…com/nofishonfriday/sws into sws-2019-09, PR reaper-oss#1122

* 'loudness-high-precision-mode-tweaks' of https://github.com/nofishonfriday/sws:
  Loudness: fix erratic results with items shorter than 3 seconds (zero-init buffer) (refix reaper-oss#1074) + add missing check normal vs. high precision mode
  Loudness: high precision mode tweaks: - fix potential crash when analyzing items shorter than 3 seconds - disable creating graph, disable go to max. short-term / momentary - ReaScript: disable 'high precision' mode for NF_AnalyzeTakeLoudness2() + SnM_Notes.cpp: fix indention

# Conflicts:
#	whatsnew.txt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant