Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REQ: Duplicate action: SWS/S&M: Remove all envelopes for selected tracks #1175

Closed
daxliniere opened this issue Aug 12, 2019 · 7 comments
Closed
Assignees

Comments

@daxliniere
Copy link

Hey team,
Could somebody please duplicate the existing action SWS/S&M: Remove all envelopes for selected tracks (_S&M_REMOVE_ALLENVS) and create a version with a confirmation dialogbox?

For example, the native action Envelope: Clear envelope first displays a dialogbox asking if you're sure.

Thank you for your consideration!
Dax.

@nofishonfriday
Copy link
Collaborator

Would a script do which displays a prompt (confirmation dialog) accordingly and if confirmed calls the existing action?, Same outcome I'd think, but I'd prefer this variant to duplating it in SWS tbh.
If so I could add it to my ReaPack repo.

@daxliniere
Copy link
Author

It would work for me, but it's a bit dangerous to have an action which wipes all automation without prompting first. Is it difficult to duplicate an existing action? I figured not.

@nofishonfriday
Copy link
Collaborator

nofishonfriday commented Aug 14, 2019

it's a bit dangerous to have an action which wipes all automation without prompting first.

Point taken. :)
Wouldn't be difficult to duplicate it indeed, my thinking was something like: if we duplicate this one, which other potentially dangerous actions with no prompt get duplicated next -> bloat here we go.

But ok, would be fine by me and I'd do it, would like to get opinion from other SWS contributors though.

@nofishonfriday
Copy link
Collaborator

@daxliniere
An idea I had is doing it via an entry in the ini file. So user could put the line RemoveAllEnvsSelTracksPrompt=1 in the ini file if a prompt is wanted. If this line isn't there (or set to =0) it's without prompt.
That would avoid the action duplication (which I'm still not much a fan of tbh), wouldn't change existing behaviour but still get the posibility of a prompt if desired.

What do you think, would that cover your request?

@daxliniere
Copy link
Author

Excellent line of thinking, man!

Personally, I think it would be better to ship with the safety on, but I can work with either.

@daxliniere
Copy link
Author

In other words, I think the action should show the prompt by default, which can be disabled in the INI file.

@daxliniere
Copy link
Author

Can you write a line to the INI file from SWS? As in, when the SWS update is released, it's first job is to write that value if it doesn't already exist.

nofishonfriday added a commit to nofishonfriday/sws that referenced this issue Aug 17, 2019
….com/nofishonfriday/sws into sws-2019-08, PR reaper-oss#1179

* 'remove-all-env-for-sel-tracks-prompt' of https://github.com/nofishonfriday/sws:
  SWS/S&M: Remove all envelopes for selected tracks: prompt before executing action may be overridden by setting <REAPER resource path>/S&M.ini/[Misc]/RemoveAllEnvsSelTracksPrompt=0 closes reaper-oss#1175

# Conflicts:
#	whatsnew.txt
nofishonfriday added a commit to nofishonfriday/sws that referenced this issue Aug 17, 2019
….com/nofishonfriday/sws into sws-2019-08, PR reaper-oss#1179

* 'remove-all-env-for-sel-tracks-prompt' of https://github.com/nofishonfriday/sws:
  SWS/S&M: Remove all envelopes for selected tracks: prompt before executing action may be overridden by setting <REAPER resource path>/S&M.ini/[Misc]/RemoveAllEnvsSelTracksPrompt=0 closes reaper-oss#1175

# Conflicts:
#	whatsnew.txt
nofishonfriday added a commit to nofishonfriday/sws that referenced this issue Aug 17, 2019
….com/nofishonfriday/sws into sws-2019-08, PR reaper-oss#1179

* 'remove-all-env-for-sel-tracks-prompt' of https://github.com/nofishonfriday/sws:
  SWS/S&M: Remove all envelopes for selected tracks: prompt before executing action may be overridden by setting <REAPER resource path>/S&M.ini/[Misc]/RemoveAllEnvsSelTracksPrompt=0 closes reaper-oss#1175

# Conflicts:
#	whatsnew.txt
@nofishonfriday nofishonfriday self-assigned this Sep 3, 2019
nofishonfriday added a commit to nofishonfriday/sws that referenced this issue Sep 12, 2019
….com/nofishonfriday/sws into sws-2019-09, PR reaper-oss#1179

* 'remove-all-env-for-sel-tracks-prompt' of https://github.com/nofishonfriday/sws:
  SWS/S&M: Remove all envelopes for selected tracks: prompt before executing action may be overridden by setting <REAPER resource path>/S&M.ini/[Misc]/RemoveAllEnvsSelTracksPrompt=0 closes reaper-oss#1175

# Conflicts:
#	whatsnew.txt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants