Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: SWS Notes window Wrap text UTF-8 bug #1252

Closed
X-Raym opened this issue Dec 12, 2019 · 3 comments · Fixed by #1254
Closed

Bug: SWS Notes window Wrap text UTF-8 bug #1252

X-Raym opened this issue Dec 12, 2019 · 3 comments · Fixed by #1254
Assignees
Labels

Comments

@X-Raym
Copy link
Contributor

X-Raym commented Dec 12, 2019

Hi,

In SWS Notes window, when unchecking the Wrap Text messes all the non ASCII characters (é,à etc) in the text editing window (these errors are then propagated to the items notes).

Demo:

img

REAPER 6.01 and SWS 2.11.0

Thx!

@cfillion
Copy link
Collaborator

Good catch! It's getting the text in UTF-8 but setting it using an ANSI function.

@cfillion cfillion self-assigned this Dec 13, 2019
@cfillion cfillion added the bug label Dec 13, 2019
@cfillion
Copy link
Collaborator

cfillion commented Dec 14, 2019

Wrap text is also broken on macOS and Linux... there it only reopens the dialog box without actually wrapping the text.

EDIT: ...and on Windows anything past the 256th character is truncated (in addition to the bad encoding conversion).

cfillion added a commit to cfillion/sws that referenced this issue Dec 15, 2019
@cfillion
Copy link
Collaborator

@X-Raym The builds are here if you'd like to try the fix early: #1254 (comment).

@cfillion cfillion linked a pull request Mar 12, 2020 that will close this issue
cfillion added a commit to cfillion/sws that referenced this issue Mar 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants