Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Actions: SWS/S&M: Dump action list (all but custom actions) and SWS/S&M: Dump action list (custom actions only) #1357

Closed
Buy-One opened this issue May 21, 2020 · 2 comments · Fixed by #1358
Closed

Actions: SWS/S&M: Dump action list (all but custom actions) and SWS/S&M: Dump action list (custom actions only) #1357

Buy-One opened this issue May 21, 2020 · 2 comments · Fixed by #1358
Assignees
@cfillion
Labels
bug

Comments

@Buy-One
Copy link

Buy-One commented May 21, 2020 •
edited
Loading

Both actions create a dump of the entire action list due to having the same command ID as the action SWS/S&M: Dump action list (all actions) namely _S&M_DUMP_CUST_ACTION_LIST.

When copying their names what gets copied is the name of the action SWS/S&M: Dump action list (all actions).

Need their own command IDs
@Buy-One Buy-One closed this as completed May 21, 2020
@Buy-One Buy-One reopened this May 21, 2020
@Buy-One Buy-One changed the title Actions: _S&M_DUMP_CUST_ACTION_LIST and _S&M_DUMP_CUST_ACTION_LIST Actions: SWS/S&M: Dump action list (all actions) and SWS/S&M: Dump action list (all actions) May 21, 2020
@Buy-One Buy-One changed the title Actions: SWS/S&M: Dump action list (all actions) and SWS/S&M: Dump action list (all actions) Actions: SWS/S&M: Dump action list (all but custom actions) and SWS/S&M: Dump action list (custom actions only) May 21, 2020
@cfillion
Copy link
Member

Looks like it's been that way since these two actions were added in 2016... Fixing!

@cfillion cfillion self-assigned this May 21, 2020
@cfillion cfillion linked a pull request May 21, 2020 that will close this issue
Fix dump action list (all but custom actions) and (all actions) #1358
Merged
@Buy-One
Copy link
Author

Buy-One commented May 21, 2020

Thank you

@cfillion cfillion added the bug label May 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cfillion cfillion

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix dump action list (all but custom actions) and (all actions) cfillion/sws
2 participants
@cfillion @Buy-One