Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reaper.BR_EnvSetProperties killing/ P_EXT for envelopes #1385

Closed
estrica2000 opened this issue Jun 22, 2020 · 5 comments · Fixed by #1387
Closed

reaper.BR_EnvSetProperties killing/ P_EXT for envelopes #1385

estrica2000 opened this issue Jun 22, 2020 · 5 comments · Fixed by #1387
Assignees
Labels

Comments

@estrica2000
Copy link

estrica2000 commented Jun 22, 2020

When setting a P_EXT for envelopes with reaper.GetSetEnvelopeInfo_String(Envelope, "P_EXT:example", "Some value", true)

and after use reaper.BR_EnvSetProperties , those P_EXT disappear. but if repeated they stay:
Check the gif: https://imgur.com/pJVn4AZ

Using this lua :
--====================================================================
function msg(param)
reaper.ShowConsoleMsg("\n"..tostring(param));
end

Envelope = reaper.GetSelectedEnvelope(0)
--====================================================================
if Envelope == nil then msg ("Select an envelope") return false end
--====================================================================

reaper.GetSetEnvelopeInfo_String(Envelope, "P_EXT:example", "Some value", true)

retval, value = reaper.GetSetEnvelopeInfo_String(Envelope, "P_EXT:example", "", false)
msg ("P_EXT:example holds value:"..value)

local br_env = reaper.BR_EnvAlloc(Envelope, false )
reaper.BR_EnvSetProperties(
br_env,
true,
true,
true,
true,
10,
0,
true
)
--====================================================================
reaper.BR_EnvFree( br_env, true )
-- after using reaper.BR_EnvAlloc the value disappears but only on the first run on that envelope
retval, value = reaper.GetSetEnvelopeInfo_String(Envelope, "P_EXT:example", "", false)
msg ("P_EXT:example holds value:"..value)

@nofishonfriday
Copy link
Collaborator

Thanks for the test script, confirmed.

@estrica2000
Copy link
Author

Thank you nofish for the commit! i have no idea where to get the new SWS version with this fix, so i can test it. Could anyone tell me?

@nofishonfriday
Copy link
Collaborator

nofishonfriday commented Jul 10, 2020

If you're on Win/Linux, builds for testing are here:
#1387 (comment)

@estrica2000
Copy link
Author

Thank you ! unfortunetly not: OSX ! i guess i'll have to wait! any chance to know how often and where i should look for in the future?

@nofishonfriday
Copy link
Collaborator

@estrica2000
Took longer than expected that I can do Mac builds again (had to upgrade system),
but if you're still interested, here's a Mac version with the potential fix:
https://www.dropbox.com/s/lf8y6pqlfkx4bp0/reaper_sws-x86_64.dylib?dl=1

(If you test let me know how it goes. :))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants