Skip to content

Bug: "Xenakios/SWS: Rename takes and source files..." deletes file with the same name on MAC. #1498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
AZpercussion opened this issue Jan 19, 2021 · 1 comment · Fixed by #1492
Closed

Bug: "Xenakios/SWS: Rename takes and source files..." deletes file with the same name on MAC. #1498

AZpercussion opened this issue Jan 19, 2021 · 1 comment · Fixed by #1492

Comments

@AZpercussion
Copy link

I had need to rename manually several items.
But by accident I named one take the same as the another. And the old source file has been deleted.
It works normally on PC. Just renames take, but not source.
On MAC it deletes file!!
nofishonfriday added a commit to nofishonfriday/sws that referenced this issue Jan 30, 2021
@nofishonfriday
Xenakios Rename take(s) (and source files): warn when filename alread…
857c698 
…y exists

closes reaper-oss#407, closes reaper-oss#1498
@nofishonfriday nofishonfriday mentioned this issue Jan 30, 2021
Merged
nofishonfriday added a commit to nofishonfriday/sws that referenced this issue Feb 3, 2021
@nofishonfriday
Xenakios Rename take(s) (and source files): warn when filename alread…
a1302f0 
…y exists, closes reaper-oss#407, closes reaper-oss#1498

combine 'Xenakios/SWS: Rename take source files...' and 'Xenakios/SWS: Rename takes and source files...' into one function for avoiding code duplication
API: import GetPeakFileNameEx()
nofishonfriday added a commit to nofishonfriday/sws that referenced this issue Feb 4, 2021
@nofishonfriday
Xenakios Rename take(s) (and source files): warn when filename alread…
c8dc020 
…y exists, closes reaper-oss#407, closes reaper-oss#1498

combine 'Xenakios/SWS: Rename take source files...' and 'Xenakios/SWS: Rename takes and source files...' into one function for avoiding code duplication
API: import GetPeakFileNameEx()
nofishonfriday added a commit to nofishonfriday/sws that referenced this issue Feb 5, 2021
@nofishonfriday
Xenakios Rename take(s) (and source files): warn when filename alread…
b2a09b6 
…y exists, closes reaper-oss#407, closes reaper-oss#1498

combine 'Xenakios/SWS: Rename take source files...' and 'Xenakios/SWS: Rename takes and source files...' into one function for avoiding code duplication
API: import GetPeakFileNameEx()
nofishonfriday added a commit to nofishonfriday/sws that referenced this issue Feb 5, 2021
@nofishonfriday
Xenakios Rename take(s) (and source files): warn when filename alread…
74dedaa 
…y exists, closes reaper-oss#407, closes reaper-oss#1498

This is extracted from PR reaper-oss#1492 to be included in upcoming next major SWS version (as the complete PR needs a bit of pre-release time).
cfillion pushed a commit that referenced this issue Feb 5, 2021
@nofishonfriday @cfillion
Xenakios Rename take(s) (and source files): warn when filename alread…
f99a2c0 
…y exists

Closes #407, closes #1498

This is extracted from PR #1492 to be included in upcoming next major SWS version (as the complete PR needs a bit of pre-release time).
nofishonfriday added a commit to nofishonfriday/sws that referenced this issue Feb 6, 2021
@nofishonfriday
Xenakios Rename take(s) (and source files): warn when filename alread…
531fc6d 
…y exists, closes reaper-oss#407, closes reaper-oss#1498

combine 'Xenakios/SWS: Rename take source files...' and 'Xenakios/SWS: Rename takes and source files...' into one function for avoiding code duplication
API: import GetPeakFileNameEx()
@swstim swstim closed this as completed in 1e50313 Feb 6, 2021
nofishonfriday added a commit to nofishonfriday/sws that referenced this issue Feb 9, 2021
@nofishonfriday
Xenakios Rename take(s) (and source files): warn when filename alread…
d4ea7ec 
…y exists, closes reaper-oss#407, closes reaper-oss#1498

combine 'Xenakios/SWS: Rename take source files...' and 'Xenakios/SWS: Rename takes and source files...' into one function for avoiding code duplication
API: import GetPeakFileNameEx()
@AZpercussion
Copy link
Author

It warns when filename already exists, thats good update. But on mac that's still potentially dangerous function. Because it still deletes already named files with the same name.
By the way, the button Yes is in focus on prompt, that is more dangerouse.

nofishonfriday added a commit to nofishonfriday/sws that referenced this issue Feb 20, 2021
@nofishonfriday
Xenakios Rename take(s) (and source files): warn when filename alread…
0f5f8df 
…y exists, closes reaper-oss#407, closes reaper-oss#1498

combine 'Xenakios/SWS: Rename take source files...' and 'Xenakios/SWS: Rename takes and source files...' into one function for avoiding code duplication
API: import GetPeakFileNameEx()
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@AZpercussion