Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

notes/help: Track notes-when docked, all of the entered text becomes selected when docker tab is clicked #225

Closed
Jeff0S opened this Issue Jul 8, 2014 · 13 comments

Comments

Projects
None yet
1 participant
@Jeff0S
Copy link
Member

Jeff0S commented Jul 8, 2014

From greypu...@gmail.com on January 04, 2011 05:14:03

What steps will reproduce the problem? Dock the Notes/Help. Enter some text in the Track notes mode (or any mode). Click any other docked tab then click back to the Notes/Help

What is the expected output? What do you see instead? All of your entered text is highlighted and very susceptible to erasing with a single space bar click or any other key.

Also, when typing into Track Notes mode only, a new Undo entry in created for each keystroke. I'd rather have nothing show up in the Undo History list regarding Notes/Help.

What version of SWS extension are you using? (Extensions -> About SWS...) 1.8.6 #7

What Reaper version #? 3.74 and 4 Alpha 22

Original issue: http://code.google.com/p/sws-extension/issues/detail?id=225

@Jeff0S

This comment has been minimized.

Copy link
Member Author

Jeff0S commented Jul 8, 2014

From jeffos...@gmail.com on January 04, 2011 09:03:24

hi, I'll look if something better can be done for the 1st "issue" (highlighted text by default). However, the 2nd issue (undo points) is not one, it's "by design": I worked a lot around that, this is a complicated issue (undos and notes persistency are tied). In short, it prevents a worse issue where notes could be lost.
I let this ticket opened for the highlighting thing (as a FR) but no change about the 2nd one (undo), sorry.

Labels: -Type-Defect -Priority-Medium Type-Enhancement Priority-Low

@Jeff0S

This comment has been minimized.

Copy link
Member Author

Jeff0S commented Jul 8, 2014

From jeffos...@gmail.com on January 04, 2011 09:03:49

Owner: jeffos277

@Jeff0S

This comment has been minimized.

Copy link
Member Author

Jeff0S commented Jul 8, 2014

From jeffos...@gmail.com on January 14, 2011 05:06:33

hey, about the annoying highlighted text: I don't confirm that (on Win XP at least!). Which OS and version are you using ?

Status: Investigating

@Jeff0S

This comment has been minimized.

Copy link
Member Author

Jeff0S commented Jul 8, 2014

From greypu...@gmail.com on January 19, 2011 11:46:03

I replied to the last email but I'm not sure if you got it. Here is the LiceCap showing what happens on my XP SP3 machine. http://img87.imageshack.us/img87/5792/notesandhelp.gif Notice the text is not selected when I click on the mixer tab, then I click the Notes/Help tab and the text is all selected in blue. Very easy to hit any character and erase the whole thing.

Chris

@Jeff0S

This comment has been minimized.

Copy link
Member Author

Jeff0S commented Jul 8, 2014

From jeffos...@gmail.com on January 19, 2011 12:22:11

Thanks for the LICECap, Chris!
Dang! XP here too and I'm not reproducing this (SWS 2.0.0 beta build #1): I attached an anim what I'm seeing.. Is it same for you with this beta ?

Attachment: noteshelp.gif

@Jeff0S

This comment has been minimized.

Copy link
Member Author

Jeff0S commented Jul 8, 2014

From greypu...@gmail.com on January 19, 2011 13:28:46

Okay, so Notes/Help works as you described when it is Docked in a docker attached to the main arrange window. The problem occurs when it is a free floating docker that is not attached to the main window. Also, the native Item Properties window exhibits similar behavior in that the Take name under Take Properties is highlighted in blue when docked in a free floating docker.

Any thoughts (aside from "Dock your dockers young man")? ;-)

@Jeff0S

This comment has been minimized.

Copy link
Member Author

Jeff0S commented Jul 8, 2014

From greypu...@gmail.com on January 19, 2011 13:33:47

More Info: It only works as you describe when I drag the window to bottom of the main window and release when I see the blue location line. If I right click and select "Attach Docker to main window" I get the problem as I describe.

@Jeff0S

This comment has been minimized.

Copy link
Member Author

Jeff0S commented Jul 8, 2014

From jeffos...@gmail.com on January 20, 2011 02:50:53

Yes, undocked: confirmed Chris! Thanks for hanging-on!
As REAPER indeed behaves like this natively too I'm not sure I can do something.. but I'll definitly have a look (just in case: I of course agree this is not cool).
ps: what's your username @ REAPER forums?

@Jeff0S

This comment has been minimized.

Copy link
Member Author

Jeff0S commented Jul 8, 2014

From greypu...@gmail.com on January 20, 2011 03:22:22

No worries. Thank you for looking at this with me. After sending my last message, I messed with it a bit more. Its even a little less predictable than what I'd described above. But you get the general idea. My username @ REAPER is just my name, chriscomfort . Anyway, thanks again.

Chris

@Jeff0S

This comment has been minimized.

Copy link
Member Author

Jeff0S commented Jul 8, 2014

From jeffos...@gmail.com on January 20, 2011 14:36:07

ok I know what's going on.. fix coming soon

Status: Started

@Jeff0S

This comment has been minimized.

Copy link
Member Author

Jeff0S commented Jul 8, 2014

From jeffos...@gmail.com on January 22, 2011 08:36:30

fixed in official and beta versions ( r252 , r254 )
Chris, I keep in mind the undo stuff, as noted in the code..)

Status: Fixe²d

@Jeff0S

This comment has been minimized.

Copy link
Member Author

Jeff0S commented Jul 8, 2014

From jeffos...@gmail.com on January 22, 2011 08:37:49

Status: Fixed

@Jeff0S

This comment has been minimized.

Copy link
Member Author

Jeff0S commented Jul 8, 2014

From greypu...@gmail.com on January 28, 2011 11:04:17

I just got a chance to try it. You're awesome. Thank you for taking the time to do it.

Chris

@Jeff0S Jeff0S closed this Jul 8, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.