Support unquantized offsets in in-project MIDI takes

[Jeff0S]

From fingersmcgarnickle on January 16, 2011 02:09:30

Currently I don't support this, the current code corrupts the unquantized offsets.

I already have written code to support it.

Original issue: http://code.google.com/p/sws-extension/issues/detail?id=234

[Jeff0S]

From fingersmcgarnickle on January 15, 2011 17:12:09

Tim, not sure what is going on with OSX support on your end. Should I submit this under my branch and you can merge? Merging code sucks which is the reason I haven't submitted. Only RprMidiTake.cxx, RprMidiEvent.cxx and RprMidiEvent.hxx are affected.

[Jeff0S]

From swstim on January 17, 2011 20:30:59

I don't mind merging, submit away. The port is temporary stalled while I work on some v4 issues.

Tim

Status: Started

[Jeff0S]

From fingersmcgarnickle on January 19, 2011 04:58:41

How far did you get? I have access to a mac so can work on it.

[Jeff0S]

From swstim on January 19, 2011 15:03:25

Merge was easy, thanks.

Down to 14 build errors + then testing. I'll commit soon so you can see, but to summarize:

• GCC is much more stringent about some C++ syntax; had to rewrite a couple things
• Moved from win32 specific open/save dialogs and FindFirst.. etc to WDL equivs
• Some .rc changes. Biggest is I had to remove your spin control because that's not supported in OSX. I haven't done it yet but maybe just rewrite to use two little buttons? How married are you to that spin control?

[Jeff0S]

From fingersmcgarnickle on January 19, 2011 17:31:59

GCC can be a PITA. Visual studio is much more forgiving. I don't really care about the spin control as long as the functionality is the same. Submit and I'll finish it and test.

[Jeff0S]

From swstim on January 19, 2011 22:13:36

OK committed my OSX changes so you can have a look.

[Jeff0S]

From swstim on January 22, 2011 10:05:30

r343

Status: Fixed