New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FR: action to "create markers/regions by items" could hopefully include empty items too #281

Closed
Jeff0S opened this Issue Jul 8, 2014 · 3 comments

Comments

Projects
None yet
1 participant
@Jeff0S
Member

Jeff0S commented Jul 8, 2014

From musicbynumbers@gmail.com on March 27, 2011 19:46:39

Dear Tim and Jeffos :)

It would be amazing if along with being to turn audio and midi items into regions or markers, empty items (and their text) could also be turned into regions or markers too.

The reason for this is that it's really nice to be able to use empty items when working with video as you can see the description in the item itself but sometimes for snapping you need to have them also as markers or regions and at the moment there seems to be no way of doing this :)

thanks! ;)

Original issue: http://code.google.com/p/sws-extension/issues/detail?id=281

@Jeff0S

This comment has been minimized.

Show comment
Hide comment
@Jeff0S

Jeff0S Jul 8, 2014

Member

From supreme...@gmail.com on April 04, 2013 17:53:46

This seems like a really easy fix (for markers, regions are by Tim and are a bit different). It literally involves changing one parameter in function call: https://code.google.com/p/sws-extension/source/browse/trunk/Xenakios/MoreItemCommands.cpp#1443 But that makes me wonder, is there a specific reason Xenakios did it that way? Since user can dictate which items will be included in the action by doing a selection, there really seems no benefit to exclude empty items?

Some other stuff that uses that same function (XenGetProjectItems) could also be improved in the same simple way.

Member

Jeff0S commented Jul 8, 2014

From supreme...@gmail.com on April 04, 2013 17:53:46

This seems like a really easy fix (for markers, regions are by Tim and are a bit different). It literally involves changing one parameter in function call: https://code.google.com/p/sws-extension/source/browse/trunk/Xenakios/MoreItemCommands.cpp#1443 But that makes me wonder, is there a specific reason Xenakios did it that way? Since user can dictate which items will be included in the action by doing a selection, there really seems no benefit to exclude empty items?

Some other stuff that uses that same function (XenGetProjectItems) could also be improved in the same simple way.

@Jeff0S

This comment has been minimized.

Show comment
Hide comment
@Jeff0S

Jeff0S Jul 8, 2014

Member

From jeffos...@gmail.com on April 05, 2013 04:51:48

No good reason at all, do not hesistate, go on Breeder!

BTW I think it is me who moded this code.. someone complained this action was too slow or something (Xen was moving the cursor and then calling the "add marker" action), may be I just did a bad copy/paste at that time?

Member

Jeff0S commented Jul 8, 2014

From jeffos...@gmail.com on April 05, 2013 04:51:48

No good reason at all, do not hesistate, go on Breeder!

BTW I think it is me who moded this code.. someone complained this action was too slow or something (Xen was moving the cursor and then calling the "add marker" action), may be I just did a bad copy/paste at that time?

@Jeff0S

This comment has been minimized.

Show comment
Hide comment
@Jeff0S

Jeff0S Jul 8, 2014

Member

From supreme...@gmail.com on April 06, 2013 23:17:06

Thanks for the reply Jeffos.

Done for the next build.

Status: Fixed

Member

Jeff0S commented Jul 8, 2014

From supreme...@gmail.com on April 06, 2013 23:17:06

Thanks for the reply Jeffos.

Done for the next build.

Status: Fixed

@Jeff0S Jeff0S closed this Jul 8, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment