New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shortcircuit and "set fx online" will get reaper to freeze #317

Closed
Jeff0S opened this Issue Jul 8, 2014 · 10 comments

Comments

Projects
None yet
1 participant
@Jeff0S
Member

Jeff0S commented Jul 8, 2014

From mths.f...@googlemail.com on June 28, 2011 18:00:19

What steps will reproduce the problem? Maybe a bit too specific but setting shortcircuit 1.1.2 (pretty common freeware-sampler, dl -> http://www.vemberaudio.se/pd/shortcircuit/shortcircuit-1_1_2.exe ) online in offline status will freeze reaper with actions:

SWS/S&M: Set FX x online for selected tracks
SWS/S&M: Toggle all/FX x online/offline for selected tracks

Sorry guys i wouldnt had posted it here, if it would happen with reaper's native actions too :).
But i dont care too much if its not fixable, just was observing..

What version of SWS extension are you using? (Extensions -> About SWS...)
2.0.0 B28 What is your Reaper version number and CPU architecture (e.g. Reaper 3.75 x64)? v4b12 What operating system are you running? (e.g. Windows XP/7, OSX 10.5.8 etc, 64bit?) win xp x86 sp3

Cheers
Veto

Attachment: sampleproject_shortcircuit_set_fx_online.RPP

Original issue: http://code.google.com/p/sws-extension/issues/detail?id=317

@Jeff0S

This comment has been minimized.

Member

Jeff0S commented Jul 8, 2014

From jeffos...@gmail.com on June 29, 2011 12:42:08

thanks for the report vetto!

I know this plug quite, well. I used it. Unfortunately, I consider it as buggy so I already dare I can't do something but I'll have a look. also, thx for the attached RPP too, it'll help!

Status: Investigating

@Jeff0S

This comment has been minimized.

Member

Jeff0S commented Jul 8, 2014

From jeffos...@gmail.com on June 30, 2011 00:57:57

Ok, confirmed in the offline->online direction and ONLY when the plug GUI (or related FX chain) is opened. I don't have shortcicuit sources but this is most probably due to an error in the GUI mgmt..
That being said, it's a "classic" issue, so if acceptable (?) I can most probably bring plugs online with closed GUI.

@Jeff0S

This comment has been minimized.

Member

Jeff0S commented Jul 8, 2014

From mths.f...@googlemail.com on June 30, 2011 03:18:30

Great Jeffos, thanks for looking into that,
Just tested this again, your right, it only happens when the gui is opened. Thats great!
I think it would be more than acceptable :) if you have the time and not least the nerves to change all that code.
Like i posted above and since i know this happens only when the gui is open, this is anything but a biggy for me.

Thanks again Jeffos

@Jeff0S

This comment has been minimized.

Member

Jeff0S commented Jul 8, 2014

From jeffos...@gmail.com on June 30, 2011 12:18:06

Fixed in r506 .

In fact I noticed also docks "onlined" floating FX. This is what does the "fix" too.

NOTE: you'll need to set "BuggyPlugsSupport=1" in the S&M.ini file, it's delivered disbaled (issue only seen with shortcircuit + the fix could slow down things a little bit).

Status: Fixed

@Jeff0S

This comment has been minimized.

Member

Jeff0S commented Jul 8, 2014

From jeffos...@gmail.com on June 30, 2011 12:19:06

^^ [..]I noticed REAPER also docks[...]

@Jeff0S

This comment has been minimized.

Member

Jeff0S commented Jul 8, 2014

From mths.f...@googlemail.com on June 30, 2011 13:11:05

whoops that was quick :) awesomness!
downloaded and ready to check in the next minutes.
Also brilliant adds on th eother stuff!
i guess i have to update the cycling actions ALR ;D

@Jeff0S

This comment has been minimized.

Member

Jeff0S commented Jul 8, 2014

From mths.f...@googlemail.com on June 30, 2011 13:35:25

It works a charm!!
Also congrats on the cycle action editor, absolutely great work!
cheers
V

@Jeff0S

This comment has been minimized.

Member

Jeff0S commented Jul 8, 2014

From jeffos...@gmail.com on July 01, 2011 02:32:36

thanks Veto! Yeah.. I thought about you and your great doc when coding the cycle action editor.. It's good to wait a bit when a brand new feature arrives :)
I'll take care of the update ("at some point").

@Jeff0S

This comment has been minimized.

Member

Jeff0S commented Jul 8, 2014

From mths.f...@googlemail.com on July 01, 2011 03:18:41

hey jeffos no prob,
i like it when tools improve and documenting about new features is always a pleasure. Though you're right about about the waiting thing.

@Jeff0S

This comment has been minimized.

Member

Jeff0S commented Jul 8, 2014

From jeffos...@gmail.com on July 01, 2011 13:35:52

Owner: jeffos...@gmail.com

@Jeff0S Jeff0S closed this Jul 8, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment