New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

auto-cons osx - can't rename #319

Closed
Jeff0S opened this Issue Jul 8, 2014 · 11 comments

Comments

Projects
None yet
1 participant
@Jeff0S
Member

Jeff0S commented Jul 8, 2014

From greg.so...@gmail.com on July 01, 2011 02:19:46

hey,

I can;t double click> enter a name in the auto icons. im on osx, as others have said it works fine on windows.

Osx 10.6.4, and newest sws beta\reaper

Original issue: http://code.google.com/p/sws-extension/issues/detail?id=319

@Jeff0S

This comment has been minimized.

Member

Jeff0S commented Jul 8, 2014

From greg.so...@gmail.com on June 30, 2011 21:47:10

hey, I also posted this in the SWS pre-release thread. I'm not sure if the behaviour is intended - thoug I do hope you see my reasoning http://forum.cockos.com/showpost.php?p=768380&postcount=534

@Jeff0S

This comment has been minimized.

Member

Jeff0S commented Jul 8, 2014

From jeffos...@gmail.com on July 01, 2011 02:30:05

#1: do you mean when you dbl-click something in the filter column ? If so do you have the same problem when you dbl-click something in.. say, the name column of the resources view?
#2: I replied in the linked thread (it's by design)

@Jeff0S

This comment has been minimized.

Member

Jeff0S commented Jul 8, 2014

From jeffos...@gmail.com on July 01, 2011 02:35:36

about #1, how did you managed to enter the string "drums" if you can't edit that !?

@Jeff0S

This comment has been minimized.

Member

Jeff0S commented Jul 8, 2014

From greg.so...@gmail.com on July 01, 2011 10:44:03

hey,

Yes, when double clicking in the filter column is what I mean. Not sure what you men by resource view, though if you mean the resoucres for fx chains and track templates, no I can't enter names their either. I manged to input names by editing the autoicons.ini and putting the names in the field their.

On the second point, I still disagree. If "any" and "unnamed" have no icons assigned, I don't see why anything underthose catagories whould get affected. If someting was named drums, and now it's "snare" I still might want it's Icon to be the same as it was. If there is no specifier for "snare" then i really don't see the logic in it's changing icon, when as I say - "any" and :unamed" are not assigned - Snnare would then be "any" and there is nothing assigned to any so it should stay as it is. So I believe auto assigned icons shoud stay unless over-ridden by a new filter\specifier, kif there is no other specifier they should STAY!! :)

Anyway tha's my opinion :) and I'm sticking to it! You have to understand drag and drop icons isn;t supported on OSX, so it's a real PITA to assign them. I thought\hoped with the auto-icon i could work around this, but alas maybe it is not meant to be

tx for all the work

@Jeff0S

This comment has been minimized.

Member

Jeff0S commented Jul 8, 2014

From jeffos...@gmail.com on July 01, 2011 11:33:08

about #1: the ini file.. ha ha! Well done gwok! so ok, something arround cell edition got broken on OSX. I can look in the recent changes but no mac here..

@Jeff0S

This comment has been minimized.

Member

Jeff0S commented Jul 8, 2014

From jeffos...@gmail.com on July 04, 2011 02:36:29

@tim. About #1, possible reasons (?):

  • WDL/SWELL problem: the GIT master's log shows a lot of updates (and reverts) around listviews & focus
    => may be a 1st easy test would just be to re-build with an older WDL version and check if it occurs
  • r481 or r504 (slight EditListItemEnd() mods. I don't believe too much in that: code performed after edition)
    => if it's due to 481: ifdef _WIN32 (it's painfull to reclick the lv after cell edition)
    => if it's due to 504: revert, I'll take care of my code using that
  • r450 (big docking update -but used to work AFAIK or that would mean nobody double-clicked a cell since march!)
    => I'm out without a mac :)
@Jeff0S

This comment has been minimized.

Member

Jeff0S commented Jul 8, 2014

From swstim on July 04, 2011 08:44:06

Thanks Jeffos for looking at this. I'll take a look first thing when I'm back from vacation.

Status: Accepted
Owner: swstim
Labels: -OpSys-All OpSys-OSX

@Jeff0S

This comment has been minimized.

Member

Jeff0S commented Jul 8, 2014

From swstim on July 06, 2011 19:56:00

Jeffos, you were on the right track, WDL is the culprit. Fixing for next release.

@Jeff0S

This comment has been minimized.

Member

Jeff0S commented Jul 8, 2014

From swstim on July 07, 2011 20:16:32

Fixed in v2.0.0 #30 r514

Status: Fixed

@Jeff0S

This comment has been minimized.

Member

Jeff0S commented Jul 8, 2014

From swstim on July 07, 2011 20:32:52

Some more tech details for the record:

So, WDL changed such that after every NM_DBLCLK message, a NM_CLICK message was sent as well. I had my code setup to cancel the editing of a field if a NM_CLICK message from the list (not the edit box) was received, so when editing it was immediately cancelled. Justin was unwilling to change WDL (it's actually slightly more like Windows this way because of some other subtle changes throughout ListView) so I made the changes in r514 sws_wnd.cpp. Now, a timer is started when editing, and if the focus changes off the edit box the editing is completed. This may be slightly better actually because if reaper is hidden because of some other window the editing is stopped.

@Jeff0S

This comment has been minimized.

Member

Jeff0S commented Jul 8, 2014

From greg.so...@gmail.com on July 07, 2011 21:10:35

good shit!!

@Jeff0S Jeff0S closed this Jul 8, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment