Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autocolor for markers/regions #339

Closed
Jeff0S opened this issue Jul 8, 2014 · 16 comments
Closed

Autocolor for markers/regions #339

Jeff0S opened this issue Jul 8, 2014 · 16 comments

Comments

@Jeff0S
Copy link
Member

Jeff0S commented Jul 8, 2014

From AnalogDi...@gmail.com on August 09, 2011 19:02:34

Hi SWS team,

Please consider the idea of adding autocoloring for markers/region.

similar to how track autocoloring is done via name tagging, markers/regions can also be tagged.

Example:

Type | Name | Color
-------|------------
Marker |mistake| Red
Marker |good | Yellow
Track |guitar | Blue
Track |drums | Brown
Region |chorus | Green

Potentially autocoloring for takes can also be added with a layout like this?

Hope you guys will strongly consider this in upcoming releases! Thanks for listening.

Original issue: http://code.google.com/p/sws-extension/issues/detail?id=339

@Jeff0S
Copy link
Member Author

Jeff0S commented Jul 8, 2014

From swstim on August 19, 2011 09:29:56

Status: Accepted
Labels: Component-Color

@Jeff0S
Copy link
Member Author

Jeff0S commented Jul 8, 2014

From Brado231 on August 13, 2012 23:28:50

I was just looking for this functionality too. I think what the OP has posted is a great idea. It has been some time since it was suggested (almost a year). Is anyone working on this? If not, I'll give it a crack but may take me some time.

@Jeff0S
Copy link
Member Author

Jeff0S commented Jul 8, 2014

From swstim on August 13, 2012 23:53:39

I'm out of commission for a while as I'm in the middle of moving my house/studio/office. Feel free to take on anything you like!

@Jeff0S
Copy link
Member Author

Jeff0S commented Jul 8, 2014

From Brado231 on August 20, 2012 20:35:24

Progress is going quicker than I expected. I may have something soon (as in the next week - maybe sooner depending on my life situation).

@Jeff0S
Copy link
Member Author

Jeff0S commented Jul 8, 2014

From lawrs....@gmail.com on September 04, 2012 12:44:51

Any luck with this so far? Still hoping for this to come someday

@Jeff0S
Copy link
Member Author

Jeff0S commented Jul 8, 2014

From Brado231 on September 04, 2012 14:42:04

Yep still doing it. It is probably 80% complete but haven't had time to finish it as I have been heavily under the pump at work and haven't been able to touch it in the last week. I'm going to try to get back on it today.
Is it region or marker coloring you are most interested in? I almost have the region stuff done.

@Jeff0S
Copy link
Member Author

Jeff0S commented Jul 8, 2014

From Brado231 on September 19, 2012 05:31:29

An update... just got back onto it tonight... sorry things have been hectic. I have autocolouring of regions working. See attached screenshot. I still have some coding and testing to do to tidy up some loose ends but hopefully that wont take too long. I also haven't done anything on markers yet, but that should be pretty easy to fit in once I have the rest sorted as the code for that is very similar to regions.

Once done, I'll submit it for code review and hopefully incorporation into an upcoming release. Shouldn't be too far off now for anyone waiting.

Attachment: AutoCol.JPG

@Jeff0S
Copy link
Member Author

Jeff0S commented Jul 8, 2014

From Brado231 on September 20, 2012 15:55:21

Markers are done now and I have also done some other fixes. The main thing left to do now is upgrade older versions of the ini file on first run to prevent settings from being lost by people already using the existing version of the plugin. Starting from fresh is fine at the moment, but I suspect people will want to keep their existing settings instead of having to reenter all of them.

As soon as I can work out how to do this I'll submit my updated code to the repository.

@Jeff0S
Copy link
Member Author

Jeff0S commented Jul 8, 2014

From Brado231 on September 21, 2012 04:20:42

Done. I'll run some of my own tests and then I'll upload for review.

@Jeff0S
Copy link
Member Author

Jeff0S commented Jul 8, 2014

From Brado231 on October 01, 2012 04:02:17

The change for this is done now.

Status: Fixed

@Jeff0S
Copy link
Member Author

Jeff0S commented Jul 8, 2014

From lawrs....@gmail.com on October 03, 2012 00:51:18

Thanks!!! How do we get your fixed version? :)

@Jeff0S
Copy link
Member Author

Jeff0S commented Jul 8, 2014

From Brado231 on October 03, 2012 01:19:48

It should be in SWS Extensions 2.3.0 #5 or #6. #5 was in prerelease status before I submitted my updates so it may not make that version, but it should definitely make #6. As I'm new in this space I'm only really guessing though, as I don't know how the guys do their release cycles.

All of the code is in the repository, so if you are prepared to run prerelease software and have Visual Studio 2008 you could compile the project yourself and have it straight away (along with a lot of other updates that have been done to SWS extensions). Just one point to note though if you do decide to do that... the latest builds rely on Reaper 4.27pre (unsupported) being available to generate the header file. You can download that from landoleet.org.

@Jeff0S
Copy link
Member Author

Jeff0S commented Jul 8, 2014

From swstim on October 03, 2012 07:33:48

It will be in 2.3.0 #6.

Typically I'll build and release within a day or so of code being committed but things are thrown off at the moment because I'm in the middle of a big move.

@Jeff0S
Copy link
Member Author

Jeff0S commented Jul 8, 2014

From Brado231 on October 03, 2012 14:39:15

No probs Tim. Thanks for the info!

@Jeff0S
Copy link
Member Author

Jeff0S commented Jul 8, 2014

From lawrs....@gmail.com on October 07, 2012 08:37:38

So far so good Brado! Thanks for putting time and effort into this! I'm loving the auto region coloring !

@Jeff0S
Copy link
Member Author

Jeff0S commented Jul 8, 2014

From Brado231 on October 08, 2012 00:31:12

No problem. I'm glad you like it. I have been using it quite a bit too in my own projects.

Jeffos deserves some credit for it too as he created the original code for track autocoloring that I based my mods off, and he also tidied up some loose ends when he reviewed my code as well.

The next thing I have on the agenda is to add (any) and (unnamed) options for region and marker filters, and also to modify the code so that manual coloring regions and markers overrides autocoloring (the same way it works for tracks). Not sure when this will happen but shouldn't be too far away.

@Jeff0S Jeff0S closed this as completed Jul 8, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant