New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FR : Cycle action link to undo #361

Closed
Jeff0S opened this Issue Jul 8, 2014 · 5 comments

Comments

Projects
None yet
1 participant
@Jeff0S
Member

Jeff0S commented Jul 8, 2014

From Renaud...@gmail.com on August 27, 2011 15:46:00

When I use cycle action (I made some complex), sometimes i make mistake in one action in the cyclen so I undo (ctrl+z)

result : the action made by my step action is cancelled (which is good but my cycle action is still "at the next Step in the cycle". It's pretty annoying...

IS it possible to link cycle step with UNDOS?? I mean, if i undo my last action, the cycle action step back one step (2 if we consider the "non action command as a step)

I use 2.1.0.5 sws extensions in REAPER 4.02

Win 7 Pro 64 bit

Thank you for reading

Original issue: http://code.google.com/p/sws-extension/issues/detail?id=361

@Jeff0S

This comment has been minimized.

Member

Jeff0S commented Jul 8, 2014

From jeffos...@gmail.com on August 27, 2011 14:07:02

sure! that would be better and it should be possible.. will look!

Owner: jeffos...@gmail.com

@Jeff0S

This comment has been minimized.

Member

Jeff0S commented Jul 8, 2014

From jeffos...@gmail.com on August 27, 2011 15:05:37

I have it working.. coming soon :)

(just a prototype right now: need more time to take care of all cases, e.g. tooltips/action that are renamed after undo.

Status: Accepted

@Jeff0S

This comment has been minimized.

Member

Jeff0S commented Jul 8, 2014

From Renaud...@gmail.com on August 27, 2011 15:24:22

Thanks!

Je continue,en francais :-)

Je ne sais pas si c'est plus facil a gerer ou pas, mais vous pourriez mettre une colonne "undo point" directement dans l'editeur de cycle action, comme ca, c'est l'utilisateur qui decide comment gerer les undos en fonctions de sa cycle action... Il suffirait de mettre des u,dos point pour definir les etapes de l'undo... Surtout avec les customs qui ne sont consolidées... Suis-je clair?

@Jeff0S

This comment has been minimized.

Member

Jeff0S commented Jul 8, 2014

From jeffos...@gmail.com on August 30, 2011 13:54:41

hey Reno! I totally agree with you everything should be in French, but it would be better to enter issues in english so that anybody can understand and chime in with any other inputs..

In short, Reno is suggesting that the undo behavior (current one vs the one proposed in the OP) should be customizable in the cycle action editor.
The goal of the cycle action editor is to make thing easier and it already requires a good understanding of the action system so I don't think I'll add any other complexity (to do the that properly, undos would have to be configurable per "steps" and I can't see a good example where an user wouldn't want the FR of the OP, do you have one?)

note: also, my code makes consolidated undos between "steps".

@Jeff0S

This comment has been minimized.

Member

Jeff0S commented Jul 8, 2014

From jeffos...@gmail.com on September 01, 2011 13:28:33

done, r550

Status: Done

@Jeff0S Jeff0S closed this Jul 8, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment