Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename takes and sources overwrites other files in folder #407

Closed
Jeff0S opened this issue Jul 8, 2014 · 4 comments · Fixed by #1492
Closed

Rename takes and sources overwrites other files in folder #407

Jeff0S opened this issue Jul 8, 2014 · 4 comments · Fixed by #1492

Comments

@Jeff0S
Copy link
Member

Jeff0S commented Jul 8, 2014

From sergioar...@gmail.com on November 01, 2011 23:41:28

What steps will reproduce the problem? Rename an item using "Rename takes and source files" command. What is the expected output? What do you see instead? Renaming the items WITHOUT overwriting others with the same names. A prompt would be nice to ask if they should be overwritten.

What version of SWS extension are you using? (Extensions -> About SWS...)
2.1.0 build#1 What is your Reaper version number and CPU architecture (e.g. Reaper 3.75 x64)? 4.10 x86 What operating system are you running? (e.g. Windows XP/7, OSX 10.5.8 etc, 64bit?) W7

Original issue: http://code.google.com/p/sws-extension/issues/detail?id=407

@Jeff0S
Copy link
Member Author

Jeff0S commented Jul 8, 2014

From jeffos...@gmail.com on November 30, 2011 11:32:24

set an owner (just to "tag" the issue..)

Owner: Xenak...@gmail.com

@Breeder
Copy link
Contributor

Breeder commented Mar 14, 2019

Bump - came across this one today, it would indeed be nice to have that prompt asking for overwrite/cancel rename operation

@nofishonfriday
Copy link
Collaborator

@Breeder
Looking into it currently, but I don't quite understand the report, as there can't be more than one file with the exact same name in the same folder (to my knowledge).
So could you elaborate what exactly the issue is here?

@Breeder
Copy link
Contributor

Breeder commented Dec 31, 2020

@Breeder
Looking into it currently, but I don't quite understand the report, as there can't be more than one file with the exact same name in the same folder (to my knowledge).
So could you elaborate what exactly the issue is here?

It's been a while but I think the bug went this like:

If you have two files called:
file1.wav
file2.wav

And you use this function to rename file1.wav to file2.wav the function will simply overwrite existing file file2.wav and put file1.wav in its place but with a new name file2.wav and effectively losing original file2.wav.

@nofishonfriday nofishonfriday self-assigned this Jan 1, 2021
nofishonfriday added a commit to nofishonfriday/sws that referenced this issue Jan 1, 2021
nofishonfriday added a commit to nofishonfriday/sws that referenced this issue Jan 30, 2021
nofishonfriday added a commit to nofishonfriday/sws that referenced this issue Feb 3, 2021
…y exists, closes reaper-oss#407, closes reaper-oss#1498

combine 'Xenakios/SWS: Rename take source files...' and 'Xenakios/SWS: Rename takes and source files...' into one function for avoiding code duplication
API: import GetPeakFileNameEx()
nofishonfriday added a commit to nofishonfriday/sws that referenced this issue Feb 4, 2021
…y exists, closes reaper-oss#407, closes reaper-oss#1498

combine 'Xenakios/SWS: Rename take source files...' and 'Xenakios/SWS: Rename takes and source files...' into one function for avoiding code duplication
API: import GetPeakFileNameEx()
nofishonfriday added a commit to nofishonfriday/sws that referenced this issue Feb 5, 2021
…y exists, closes reaper-oss#407, closes reaper-oss#1498

combine 'Xenakios/SWS: Rename take source files...' and 'Xenakios/SWS: Rename takes and source files...' into one function for avoiding code duplication
API: import GetPeakFileNameEx()
nofishonfriday added a commit to nofishonfriday/sws that referenced this issue Feb 5, 2021
…y exists, closes reaper-oss#407, closes reaper-oss#1498

This is extracted from PR reaper-oss#1492 to be included in upcoming next major SWS version (as the complete PR needs a bit of pre-release time).
cfillion pushed a commit that referenced this issue Feb 5, 2021
…y exists

Closes #407, closes #1498

This is extracted from PR #1492 to be included in upcoming next major SWS version (as the complete PR needs a bit of pre-release time).
nofishonfriday added a commit to nofishonfriday/sws that referenced this issue Feb 6, 2021
…y exists, closes reaper-oss#407, closes reaper-oss#1498

combine 'Xenakios/SWS: Rename take source files...' and 'Xenakios/SWS: Rename takes and source files...' into one function for avoiding code duplication
API: import GetPeakFileNameEx()
@swstim swstim closed this as completed in 1e50313 Feb 6, 2021
nofishonfriday added a commit to nofishonfriday/sws that referenced this issue Feb 9, 2021
…y exists, closes reaper-oss#407, closes reaper-oss#1498

combine 'Xenakios/SWS: Rename take source files...' and 'Xenakios/SWS: Rename takes and source files...' into one function for avoiding code duplication
API: import GetPeakFileNameEx()
nofishonfriday added a commit to nofishonfriday/sws that referenced this issue Feb 20, 2021
…y exists, closes reaper-oss#407, closes reaper-oss#1498

combine 'Xenakios/SWS: Rename take source files...' and 'Xenakios/SWS: Rename takes and source files...' into one function for avoiding code duplication
API: import GetPeakFileNameEx()
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants