New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Play/loop media file in selected tacks(toggle),slot 'n'" actions BUGS #411

Closed
Jeff0S opened this Issue Jul 8, 2014 · 14 comments

Comments

Projects
None yet
1 participant
@Jeff0S
Member

Jeff0S commented Jul 8, 2014

From pyt...@yahoo.com on November 14, 2011 14:09:22

When using the new "Play/loop media file in selected tacks(toggle),slot 'n'" actions with MIDI files toggling does not work.
Running the action a second time to stop the MIDI ends up playing another instance. The only way I've found to stop the MIDI is to close the project. Also none of the new toggle actions State fields update.., they always show a state of "Off" even when running.

I'm using SWS version 2.1.0 #18 Win32
REAPER version 4.11rc2pre2 under WinXP

If it's not too much ask.., I was wondering if you could also add actions that when toggled would pause the media file so that when the action is ran again the media file would continue from where it was paused? They could be labeled something like....,
"Play/loop media file in selected tacks(toggle/pause),slot 'n'"

Thank You,
Anton

Original issue: http://code.google.com/p/sws-extension/issues/detail?id=411

@Jeff0S

This comment has been minimized.

Member

Jeff0S commented Jul 8, 2014

From pyt...@yahoo.com on November 14, 2011 05:16:06

Just noticed that the actions "Play media file in selected tracks(toggle), slot 'n'" also have the same problem as described above although the MIDI file does stop after one pass.

@Jeff0S

This comment has been minimized.

Member

Jeff0S commented Jul 8, 2014

From pyt...@yahoo.com on November 14, 2011 05:40:00

Just to let you know using the new "Stop playing media files" action works.., so I guess I don't have to close the project to get it to stop.

@Jeff0S

This comment has been minimized.

Member

Jeff0S commented Jul 8, 2014

From jeffos...@gmail.com on November 15, 2011 05:04:46

Hey Anton, I can confirm toggle states are not correctly reported (always "off", fix coming soon..) but I can't confirm the playing issue: all is ok here, if I use "toggle play" (or "toggle loop") actions, MIDI is correctly played on 1st execution and stopped on 2nd execution (ok with audio files too).

be careful!
as said in their names, these actions work on selected tracks: so if you run the action, select some other tracks and run the action again, it is normal the file is started again on each of these tracks. isn't it your pb?

ps: actions with "pause" would be possible..

Status: Investigating

@Jeff0S

This comment has been minimized.

Member

Jeff0S commented Jul 8, 2014

From pyt...@yahoo.com on November 15, 2011 18:14:55

Hi Jeffos,

It looks as though I've encountered another problem. Using the Play/loop toggle actions with .wav as the source.., when I toggle it to off I can't get it to start again using the toggle action however if run (Play/loop media file in selected track, slot 'n') it starts to loop again and I can use the toggle action to stop it but not restart it. The only way I can get the toggle action to work again is to create a new project. To answer your ? yes I made sure it was the same track.

I tried it on another computer and had the same issue. Both pc's have Reaper installed using the portable option.

@Jeff0S

This comment has been minimized.

Member

Jeff0S commented Jul 8, 2014

From jeffos...@gmail.com on November 16, 2011 01:21:35

Sorry but I definitely can't reproduce! All is ok here.

Please, can you enter reproduction steps of what you are doing, I mean step by step, including track selection, etc ?

Also, I'm not sure I understand.. are you now saying it is ok with MIDI but only wrong with audio?
If you use a toolbar, are you sure you didn't mix up action names (I ask because I made this error here "play/loop blabla" and "play/loop blabla (toggle)" are close names..)

thanks for hanging on, Anton! we'll sort this out!

@Jeff0S

This comment has been minimized.

Member

Jeff0S commented Jul 8, 2014

From pyt...@yahoo.com on November 16, 2011 11:06:03

Ok.., this is so strange the problem with .wav files has corrected it's self. Must have been a ghost in the machine/gremlins issue as I know for sure it wasn't user related and when I tried it today I didn't do anything different. Maybe it had something to do with the S&M.ini file and when Reaper was shut down and restarted it corrected itself ?

Now onto the MIDI issue.., I'm glad to say I tracked down the root of the problem.
It's the setting in "Preferences/Media/MIDI/Import existing MIDI files as:" option which needs to be set to ".MID file reference" in order for things to work.

Unfortunately I'm now receiving stuck notes. You don't really notice it unless you are playing through an instrument such as violin or a synth. I even tried the option under MIDI Devices for "On stop/play Send all-notes-off" but that doesn't seem to work. Please let me know if you track down what's causing this.

@Jeff0S

This comment has been minimized.

Member

Jeff0S commented Jul 8, 2014

From jeffos...@gmail.com on November 18, 2011 00:47:12

MIDI: Wow! Thank you, excellent finding Anton! Yes, I now confirm the pb when MIDI files are imported as in-project data (which is the default pref, but not here :-) => fix coming soon..
So now the last remaining issue is about stuck notes: I should be able to fix that one too..

Status: Started

@Jeff0S

This comment has been minimized.

Member

Jeff0S commented Jul 8, 2014

From jeffos...@gmail.com on November 18, 2011 15:09:40

fixed ( r633 , will be available in the next release..)

Status: Fixed
Owner: jeffos...@gmail.com

@Jeff0S

This comment has been minimized.

Member

Jeff0S commented Jul 8, 2014

From pyt...@yahoo.com on November 18, 2011 19:44:22

Hey Jeffos,

The problem with "Play/loop media file in selected tracks(toggle), slot 'n'" using .wav files has reared it's head again. I have no idea what's causing it. It was working fine for awhile then I toggled it to stop and tried to toggle it to play again and it would not play. I then cleared the slot and tried other .wav files and it's really weird some would work once then I would toggle to stop and again to play and nothing.., I clear the slot again and load a different file and toggle a bunch of times without any problem. If I try to reload one of the files I had a problem with I can't get it to play at all unless I close the project and start over.

It seems the problem happens more on my Vista system.., I did have it happen the one time on XP but I just did a bunch of tests on XP and could not reproduce.
I'll have to do some more testing on Vista tomorrow and pay close attention to see if I can narrow it down. The only thing I can think of right now that is different on the two systems is that on Vista I'm triggering the action using a MIDI keyboard. On my XP system I'm just using a shortcut key..., I don't think that's the problem, but who knows.., I let you know if I discover anything else tomorrow.

@Jeff0S

This comment has been minimized.

Member

Jeff0S commented Jul 8, 2014

From jeffos...@gmail.com on November 19, 2011 02:23:30

if you do some tests, please can you use this build instead: https://code.google.com/p/sws-extension/downloads/detail?name=reaper_sws.zip (it includes fixes discussed above + some updates that might fix the remain audio toggle issue: mutexing updates)
=> fixes it?
also, are those media files loaded elswhere? (in the projetc? retained in media bay?)

@Jeff0S

This comment has been minimized.

Member

Jeff0S commented Jul 8, 2014

From jeffos...@gmail.com on November 19, 2011 03:13:07

Just in case: just updatded the test build with a possible fix..
also, you do not have to clear/re-load/etc.. slots (old/stable code: the issue is certainly not there).

@Jeff0S

This comment has been minimized.

Member

Jeff0S commented Jul 8, 2014

From jeffos...@gmail.com on November 19, 2011 05:56:30

updated win32 test build (again, r635 ). I'm (almost) confident it can fix your issue..

Status: Started

@Jeff0S

This comment has been minimized.

Member

Jeff0S commented Jul 8, 2014

From pyt...@yahoo.com on November 19, 2011 09:14:24

Jeffos,

Woo-hoo! I've been testing the test build for the past couple of hours and things seem pretty rock solid.., I even created some cycle actions using .wav and MIDI files combined(really fun by the way) and no problems so far. Great job..., thank you so much. :)
Oh, I was just wondering if pause actions are going to be added in this next build?

@Jeff0S

This comment has been minimized.

Member

Jeff0S commented Jul 8, 2014

From swstim on November 19, 2011 10:46:22

Cool, I've posted this as 2.1.0 #20!

Status: Fixed

@Jeff0S Jeff0S closed this Jul 8, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment