Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

auto colour/icon: certain jpegs seem to crash reaper when trying to auto icon new track #576

Closed
Jeff0S opened this issue Jul 8, 2014 · 8 comments

Comments

@Jeff0S
Copy link
Member

Jeff0S commented Jul 8, 2014

From musicbynumbers@gmail.com on May 19, 2013 20:44:10

-What steps will reproduce the problem?

  1. Assign the attached image to auto icon/colour and call it "footsteps", colour it too.
  2. create new track and name it "footsteps" then double click to create a 2nd track underneath it

-What is the expected output? What do you see instead?

Expected a new track to be created but Reaper crashes with below report

Problem Event Name: BEX
Application Name: reaper.exe
Application Version: 4.4.0.15
Application Timestamp: 519646af
Fault Module Name: reaper_sws.dll
Fault Module Version: 2.3.0.17
Fault Module Timestamp: 51805e0d
Exception Offset: 0016b3a4
Exception Code: c0000409
Exception Data: 00000000
OS Version: 6.1.7601.2.1.0.256.48
Locale ID: 2057
Additional Information 1: 1abb
Additional Information 2: 1abbf100d028b68c92a2f47907642654
Additional Information 3: dd49
Additional Information 4: dd4966dee1b8a6083bbc6938b04565ca

-What version of SWS extension are you using? (Extensions -> About SWS...)

2.3.0.17 (latests as of may 19th)

-What is your Reaper version number and CPU architecture (e.g. Reaper 3.75 x64)? 441pre5 What operating system are you running? (e.g. Windows XP/7, OSX 10.5.8 etc, 64bit?) Win 7 64bit with reaper 32 bit

Attachment: footsteps_1.jpg

Original issue: http://code.google.com/p/sws-extension/issues/detail?id=576

@Jeff0S
Copy link
Member Author

Jeff0S commented Jul 8, 2014

From musicbynumbers@gmail.com on May 19, 2013 11:46:56

Think I've solved it! :) I think "_" (underscore) is an illegal character which is causing the crash. Took that out and hasn't crashed since!

@Jeff0S
Copy link
Member Author

Jeff0S commented Jul 8, 2014

From musicbynumbers@gmail.com on May 19, 2013 12:21:03

Sorry, still crashing :*(

Trying to find the pattern. I've renamed files to be solely alphabetical now so no numbers or characters and I still get crashes on jpegs when naming a track that adds the dodgy jpeg and then straight after creating a new track.

Will try converting them to PNG and see if it's a compression bug thing.

Any ideas guys? :) thanks!

@Jeff0S
Copy link
Member Author

Jeff0S commented Jul 8, 2014

From musicbynumbers@gmail.com on May 19, 2013 12:32:31

It seems to be with any files I have added recently since they don't show up in the same way on the list. They have full path names and not shorter ones which make me thing somehow autocolour is getting them in a different way? (see attached photo)

Also here's another crash log in case it's different :)

Problem Event Name: BEX
Application Name: reaper.exe
Application Version: 4.4.0.15
Application Timestamp: 519646af
Fault Module Name: reaper_sws.dll
Fault Module Version: 2.3.0.17
Fault Module Timestamp: 51805e0d
Exception Offset: 0016b3a4
Exception Code: c0000409
Exception Data: 00000000
OS Version: 6.1.7601.2.1.0.256.48
Locale ID: 2057
Additional Information 1: 76c6
Additional Information 2: 76c6834d867a92246ec761ee5dee47e4
Additional Information 3: 5350
Additional Information 4: 5350077d7e23fc30da300e44d2561836

Attachment: auto colour crash image.JPG

@Jeff0S
Copy link
Member Author

Jeff0S commented Jul 8, 2014

From jeffos...@gmail.com on May 20, 2013 01:30:14

Thanks for all the details, Matt!

Fixed for the next build ( r1080 ).

For the record, "short paths" are used for files located in REAPER resources directories (or sub-directories), full paths are used otherwise. It's REAPER convention nout ours (less blabla in RPP files, portability, etc..).
This convention is used in the S&M Resources window too.

Status: Fixed
Owner: jeffos...@gmail.com

@Jeff0S
Copy link
Member Author

Jeff0S commented Jul 8, 2014

From musicbynumbers@gmail.com on May 20, 2013 01:48:54

Thanks a lot! :) that's great news as I was just looking forward to
expanding my icons to include a kitchen sink image too!

Glad it was a quick one to find!

Matt.

@Jeff0S
Copy link
Member Author

Jeff0S commented Jul 8, 2014

From musicbynumbers@gmail.com on May 22, 2013 16:56:12

Hi Jeffos, Hope this isn't a silly question but build ( r1080 ), is that automatically part of what is now v17 (and therefore I can just download it again with auto icon fix) or is it only updated once v18 is out? :)

I'm not trying to rush the release or anything just wasn't sure if I was somehow meant to test build ( r1080 ) somehow?

If not, no worries, I have patience! :)

@Jeff0S
Copy link
Member Author

Jeff0S commented Jul 8, 2014

From jeffos...@gmail.com on May 23, 2013 16:08:11

yes, this means this fix will be part of v18 (I put commit numbers like " r1080 " as notes, just to know how what was fixed when).
I'd have to set things to "fixed" only when the builds are out though, oh well :)

@Jeff0S
Copy link
Member Author

Jeff0S commented Jul 8, 2014

From musicbynumbers@gmail.com on May 23, 2013 16:11:16

no worries! looking forward to it like the nerd I am!

Have a big project here that's currently iconless and in need of that magic assignment that auto-icon brings! ;)

@Jeff0S Jeff0S closed this as completed Jul 8, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant