Faulty Snapshot recall with LangPack used #621

Closed
Jeff0S opened this Issue Jul 8, 2014 · 12 comments

Projects

None yet

1 participant

@Jeff0S
Collaborator
Jeff0S commented Jul 8, 2014

From vsermo...@gmail.com on January 21, 2014 22:45:01

What steps will reproduce the problem? At the re-opening of the project, the snapshot no longer work properly and Reaper becomes unstable What is the expected output? What do you see instead? Volume tracks completely down without relation with the shot
And the abrupt Reaper closure sometimes.

What version of SWS extension are you using? (Extensions -> About SWS...)
The last 2.4.0.2 with the french langpatch What is your Reaper version number and CPU architecture (e.g. Reaper 3.75 x64)? with 32 bit Reaper 4.591 What operating system are you running? (e.g. Windows XP/7, OSX 10.5.8 etc, 64bit?) on Windows 7 64bit

Attachment: snapshot.gif

Original issue: http://code.google.com/p/sws-extension/issues/detail?id=621

@Jeff0S
Collaborator
Jeff0S commented Jul 8, 2014

From vsermo...@gmail.com on January 21, 2014 14:40:15

Je vien d'essayer sans charger le langpack français et ça marche. Le probleme semble venir du langpack.

google:
I just tried without loading the French langpack and it works. The problem seems to come from langpack.

@Jeff0S
Collaborator
Jeff0S commented Jul 8, 2014

From supreme...@gmail.com on January 21, 2014 15:24:10

It is possible that commit r1183 solved it.

Since we currently can't do new downloads: http://google-opensource.blogspot.com/2013/05/a-change-to-google-code-download-service.html and situation still needs to get solved, here's a test build that includes all the new code updates: https://copy.com/EAXCtnds7N0Z Can you please try it to see if it solves your problem.

@Jeff0S
Collaborator
Jeff0S commented Jul 8, 2014

From vsermo...@gmail.com on January 21, 2014 18:14:05

Il y a une amélioration avec la création de snapshot faite avec la version Anglophone de Reaper et votre nouvelle version d'extension mais l'anomalies sur les premiers snapshots des faders totalement baissé persiste. Je tien a votre disposition le RPP si cela peut vous aider.

Google:
There has improved with the creation of snapshot made ​​with the Anglophone version of Reaper and your new version of extension but the anomaly in the first snapshots of faders fully lowered persists. I remain at your disposal the RPP if it can help you.

@Jeff0S
Collaborator
Jeff0S commented Jul 8, 2014

From supreme...@gmail.com on January 21, 2014 19:19:01

At first glance it seems that volume values that your snapshots recall are correctly written to that .RPP
Which probably means that you've saved the file with the bug present. :/
I really, really hope you have backups for that project (reaper should save those automatically so there still may be hope)

Technical explanation on how the bug worked:

The problem (well, the one I'm aware of, could be more) with the bug was that if you've used langpack and had set comma (,) as a decimal mark in Window's settings a lot of stuff internally stopped working when reading decimal numbers in certain situations

Here's my take on reconstructing what happened:

  1. Save snapshot - everything works
  2. Save project - all values are correctly written to .RPP
  3. Close and reopen project
  4. SWS tries to read snapshot data from .RPP, instead of reading something like 0.456565 it would just read 0.000000 and load that into memory.
  5. Save project - all correct data gets overwritten with the wrong data

I apologize in the name of the whole SWS if this bug caused any inconvenience for you :(
But as mentioned earlier, if you got backups turned on, things might not be lost for good.

@Jeff0S
Collaborator
Jeff0S commented Jul 8, 2014

From vsermo...@gmail.com on January 21, 2014 19:46:58

Pas d'inquiétude, j'ai des copies de sauvegardes antérieur et je peux revenir facilement sur ces mixages. Merci pour votre réactivité et bonne continuation.

There are no worries, I have copies of previous backups and I can easily return to these mixes. Thank you for your response and good luck.

@Jeff0S
Collaborator
Jeff0S commented Jul 8, 2014

From jeffos...@gmail.com on January 22, 2014 01:09:34

[Just for the record] Same issue reported here http://forum.cockos.com/showthread.php?t=131970 => In private, I'm double-checking with grabie he was also running a translated version of the extension/REAPER

@Martin: I had "remove setlocale()" for a long time in my TODO list, many thanks for taking care of that! Also, a mail will follow about downloads...

@Vincent: merci pour tous les détails! Si tout le monde pouvait faire ça, ça serait + rapide/simple...

Status: Started

@Jeff0S
Collaborator
Jeff0S commented Jul 8, 2014

From jeffos...@gmail.com on January 22, 2014 04:21:48

this one stinks, indeed! after a closer look 1) Win only issue 2 ) I think the issue can be reproduced even without using a LangPack: using , instead of . in the regional settings seems enough to trigger the bug (that's also why I was unable to repro grabie's first report: everything is in English here).

Labels: -OpSys-All OpSys-Windows

@Jeff0S
Collaborator
Jeff0S commented Jul 8, 2014

From jeffos...@gmail.com on January 22, 2014 04:27:49

spoke too soon: fortunately the culprit code was: if (isLocalized()) setLocale()

... so, it only occurs when a LangPack is used

=> workaround before the next release = switch back to English (i.e. default LangPack)

@Jeff0S
Collaborator
Jeff0S commented Jul 8, 2014

From vsermo...@gmail.com on January 22, 2014 08:23:41

Un RPP backup avant la sauvegarde avec le problême vous aiderait ?

A RPP backup, before the problem you help ?

@Jeff0S
Collaborator
Jeff0S commented Jul 8, 2014

From jeffos...@gmail.com on January 24, 2014 00:53:16

Merci Vincent, mais c'est bon: le pb sera à priori corrigé dans la prochaine version...


Got some feeback from grabies (the inital reporter, no issue #, just a thread): it seems was also using a LangPack => same bug

Same bug as Issue 619 too.

Summary: Faulty Snapshot recall with LangPack used (was: Snapshot)
Status: Duplicate
Mergedinto: 619

@Jeff0S
Collaborator
Jeff0S commented Jul 8, 2014

From vsermo...@gmail.com on January 24, 2014 03:08:07

Super ! Merci

Great ! Thank's !

@Jeff0S Jeff0S closed this Jul 8, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment