New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mouse Context Stretch Marker bugs #765

Closed
X-Raym opened this Issue Sep 1, 2015 · 8 comments

Comments

Projects
None yet
2 participants
@X-Raym

X-Raym commented Sep 1, 2015

reaper.BR_GetMouseCursorContext() can return 'item_strech_marker" only if take playrate is 1, else it returns ITEM (except other special circumstances).

Consequences is that reaper.BR_GetMouseCursorContext_StretchMarker() often return -1 or nothing on strech marker on take with rate ~= 1.

You can test with https://github.com/X-Raym/REAPER-ReaScripts/blob/master/Items%20Properties/X-Raym_Reset%20stretch%20marker%20under%20mouse%20position.lua if you want !

@X-Raym X-Raym changed the title from Mouse Context Strech Marker bugs to Mouse Context Stretch Marker bugs Sep 1, 2015

@Breeder

This comment has been minimized.

Show comment
Hide comment
@Breeder

Breeder Sep 1, 2015

Contributor

This should have been fixed for the last official build. Are you testing with latest SWS?

Contributor

Breeder commented Sep 1, 2015

This should have been fixed for the last official build. Are you testing with latest SWS?

@X-Raym

This comment has been minimized.

Show comment
Hide comment
@X-Raym

This comment has been minimized.

Show comment
Hide comment

X-Raym commented Sep 1, 2015

Ok I succeed to reproduce it
http://i.giphy.com/l41lLAiUQ1I8xFY7m.gif

@Breeder

This comment has been minimized.

Show comment
Hide comment
@Breeder

Breeder Sep 1, 2015

Contributor

Can you share example project and explain exact repro steps?

Contributor

Breeder commented Sep 1, 2015

Can you share example project and explain exact repro steps?

@X-Raym

This comment has been minimized.

Show comment
Hide comment
@X-Raym

X-Raym Sep 1, 2015

  1. Open project https://www.dropbox.com/s/gxp8c6qldhmldxi/StretchMarkerBugReport.zip?dl=0
  2. Import my script https://github.com/X-Raym/REAPER-ReaScripts/blob/master/Items%20Properties/X-Raym_Reset%20stretch%20marker%20under%20mouse%20position.lua
  3. Assign a keyboard shortcut
  4. Try to make it work on the strech markers. Move strech markers and try again. => Sometimes it works, sometimes not.

If you want to do it by yourself

  1. import an audio file in the project
  2. add markers
  3. change playrate to something a bit extreme such as x2, x3 or more.
  4. use the action provided before.

X-Raym commented Sep 1, 2015

  1. Open project https://www.dropbox.com/s/gxp8c6qldhmldxi/StretchMarkerBugReport.zip?dl=0
  2. Import my script https://github.com/X-Raym/REAPER-ReaScripts/blob/master/Items%20Properties/X-Raym_Reset%20stretch%20marker%20under%20mouse%20position.lua
  3. Assign a keyboard shortcut
  4. Try to make it work on the strech markers. Move strech markers and try again. => Sometimes it works, sometimes not.

If you want to do it by yourself

  1. import an audio file in the project
  2. add markers
  3. change playrate to something a bit extreme such as x2, x3 or more.
  4. use the action provided before.
@Breeder

This comment has been minimized.

Show comment
Hide comment
@Breeder

Breeder Sep 1, 2015

Contributor

But does "sometimes it works, sometimes doesn't" happen consistently or what?
That's why I'm asking for example project - where it should be possible to consistently reproduce this :)

Contributor

Breeder commented Sep 1, 2015

But does "sometimes it works, sometimes doesn't" happen consistently or what?
That's why I'm asking for example project - where it should be possible to consistently reproduce this :)

@X-Raym

This comment has been minimized.

Show comment
Hide comment
@X-Raym

X-Raym Sep 1, 2015

I updated a project in previous post. Two tracks : one with take at x2.7 and other at x1

I just close and reopen and REAPER and problem was still their for take at x2.7

X-Raym commented Sep 1, 2015

I updated a project in previous post. Two tracks : one with take at x2.7 and other at x1

I just close and reopen and REAPER and problem was still their for take at x2.7

@Breeder

This comment has been minimized.

Show comment
Hide comment
@Breeder

Breeder Sep 1, 2015

Contributor

Ok, thanks - I'll check it out

Contributor

Breeder commented Sep 1, 2015

Ok, thanks - I'll check it out

@Breeder Breeder self-assigned this Sep 1, 2015

Breeder added a commit that referenced this issue Sep 1, 2015

Fixed issue #765 - various actions and ReaScript API weren't working …
…properly with stretch markers at mouse cursor when take playrate is modified

@X-Raym X-Raym closed this Sep 11, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment