New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Stretch Marker Mouse Context and Strech Marker Display with 5.04 pre 1 Update #771

Closed
X-Raym opened this Issue Sep 25, 2015 · 18 comments

Comments

Projects
None yet
5 participants
@X-Raym

X-Raym commented Sep 25, 2015

I'm afraid that with the last pre-release (5.04 pre1), the great updates on stretch markers broke the Get Stretch Marker Under Mouse Context... =/
It does work horizontally (where the markers are) but not vertically (we have to put the mouse where their original vertical position was, even if they are above or below).

@Breeder

This comment has been minimized.

Show comment
Hide comment
@Breeder

Breeder Sep 26, 2015

Contributor

That sucks...more reverse engineering of pixels -_- Not really sure when I will have the time for that...let pre cycle first finish to see where it ends up

Contributor

Breeder commented Sep 26, 2015

That sucks...more reverse engineering of pixels -_- Not really sure when I will have the time for that...let pre cycle first finish to see where it ends up

@daxliniere

This comment has been minimized.

Show comment
Hide comment
@daxliniere

daxliniere Nov 19, 2015

Hey guys, any news on this?

Hey guys, any news on this?

@daxliniere

This comment has been minimized.

Show comment
Hide comment
@daxliniere

daxliniere Mar 2, 2016

@Jeff0S , I've spoken with Breeder and he is no longer able to work on this. With your knowledge of and access to the inside of REAPER, are you able to get this working, please? It's a very useful part of SWS and it's killing me that scripts crucial to my workflow no longer work because of this.

@Jeff0S , I've spoken with Breeder and he is no longer able to work on this. With your knowledge of and access to the inside of REAPER, are you able to get this working, please? It's a very useful part of SWS and it's killing me that scripts crucial to my workflow no longer work because of this.

@daxliniere

This comment has been minimized.

Show comment
Hide comment
@daxliniere

daxliniere Mar 2, 2016

Honestly, I'd much prefer to go back to the old stretch marker system. I really hate the cluttered views and who ever needs rate transitions anyway? I can't imagine anything they're useful for and I've been editing audio for 20 years.
The handles are also impossible to grab when there's a volume envelope over the item set to 0dB. You actually have to hide the envelope first.

Plus, you have to reach for different places when adjusting them. That SUCKS for workflow.

I'm sure there's a better place for this conversation, I'm just not sure where it is. Please advise.

Honestly, I'd much prefer to go back to the old stretch marker system. I really hate the cluttered views and who ever needs rate transitions anyway? I can't imagine anything they're useful for and I've been editing audio for 20 years.
The handles are also impossible to grab when there's a volume envelope over the item set to 0dB. You actually have to hide the envelope first.

Plus, you have to reach for different places when adjusting them. That SUCKS for workflow.

I'm sure there's a better place for this conversation, I'm just not sure where it is. Please advise.

@daxliniere

This comment has been minimized.

Show comment
Hide comment
@daxliniere

daxliniere Mar 18, 2016

Hello? Is anyone here anymore?

Hello? Is anyone here anymore?

@jalovatt

This comment has been minimized.

Show comment
Hide comment
@jalovatt

jalovatt Feb 22, 2017

Bump, not it that it helps.

Bump, not it that it helps.

@swstim

This comment has been minimized.

Show comment
Hide comment
@swstim

swstim Feb 22, 2017

Member

Hey now, no need to be cranky. I'll take a look next time I build.

Member

swstim commented Feb 22, 2017

Hey now, no need to be cranky. I'll take a look next time I build.

@jalovatt

This comment has been minimized.

Show comment
Hide comment
@jalovatt

jalovatt Feb 22, 2017

Sorry, it's just been a year and a half since the thread was opened and I didn't think anyone was actively maintaining SWS anymore.

Sorry, it's just been a year and a half since the thread was opened and I didn't think anyone was actively maintaining SWS anymore.

@X-Raym

This comment has been minimized.

Show comment
Hide comment
@X-Raym

X-Raym Feb 22, 2017

@swstim
Thanks ! Javolatt made some suggestions about how to solve it, maybe it can help.

X-Raym commented Feb 22, 2017

@swstim
Thanks ! Javolatt made some suggestions about how to solve it, maybe it can help.

@swstim

This comment has been minimized.

Show comment
Hide comment
@swstim

swstim Feb 22, 2017

Member

FYI the bump does help - the list of bugs here is prohibitively long and it's good to know what people are hitting their heads against. I need to get an update out soon as it's been WAY too long.

Member

swstim commented Feb 22, 2017

FYI the bump does help - the list of bugs here is prohibitively long and it's good to know what people are hitting their heads against. I need to get an update out soon as it's been WAY too long.

@X-Raym

This comment has been minimized.

Show comment
Hide comment
@X-Raym

X-Raym Feb 22, 2017

@swstim Indeed, reports and FR list is long, but some issues could be closed because they are already solves like this one : #350

Reviewing all 11 pages of FR to check if it need to be closed, add BUG or FR labels, or tells that it can be scripted and doesn't need to be included right in SWS can be a bit boring, for sure. But maybe some people can help ?

X-Raym commented Feb 22, 2017

@swstim Indeed, reports and FR list is long, but some issues could be closed because they are already solves like this one : #350

Reviewing all 11 pages of FR to check if it need to be closed, add BUG or FR labels, or tells that it can be scripted and doesn't need to be included right in SWS can be a bit boring, for sure. But maybe some people can help ?

@daxliniere

This comment has been minimized.

Show comment
Hide comment
@daxliniere

daxliniere Feb 23, 2017

@swstim Thanks Tim, that's super-exciting to hear you're willing to put some time into this.

This sounds like a great solution, if it will work: "Remove the y-check entirely and just see if the mouse is within STRETCH_M_HIT_POINT of a stretch marker horizontally."

@swstim Thanks Tim, that's super-exciting to hear you're willing to put some time into this.

This sounds like a great solution, if it will work: "Remove the y-check entirely and just see if the mouse is within STRETCH_M_HIT_POINT of a stretch marker horizontally."

@daxliniere

This comment has been minimized.

Show comment
Hide comment
@daxliniere

daxliniere Feb 23, 2017

@X-Raym, great idea to do a cull. Normally I would love to help with this, but I'm neck-deep in building the studio complex in London at the moment.

@X-Raym, great idea to do a cull. Normally I would love to help with this, but I'm neck-deep in building the studio complex in London at the moment.

@swstim

This comment has been minimized.

Show comment
Hide comment
@swstim

swstim Mar 24, 2017

Member

OK - I've removed the Y hit logic per Lokasenna's suggestion here and daxliniere's agreement above. I will leave this open to maybe someday update the logic to account for actual stretch marker logic or other issues that crop up because of this change.

Member

swstim commented Mar 24, 2017

OK - I've removed the Y hit logic per Lokasenna's suggestion here and daxliniere's agreement above. I will leave this open to maybe someday update the logic to account for actual stretch marker logic or other issues that crop up because of this change.

@swstim swstim added the Priority-Low label Mar 24, 2017

@daxliniere

This comment has been minimized.

Show comment
Hide comment
@daxliniere

daxliniere Mar 25, 2017

Thank you SO MUCH Tim! I'll test this tomorrow and let you know how it goes.
(Perfect timing as I have a drum editing session tomorrow.)

Thank you SO MUCH Tim! I'll test this tomorrow and let you know how it goes.
(Perfect timing as I have a drum editing session tomorrow.)

@X-Raym

This comment has been minimized.

Show comment
Hide comment
@X-Raym

X-Raym Mar 25, 2017

Cool ! My Reset stretch marker under mouse edit may be usable again ! :P

X-Raym commented Mar 25, 2017

Cool ! My Reset stretch marker under mouse edit may be usable again ! :P

@daxliniere

This comment has been minimized.

Show comment
Hide comment
@daxliniere

daxliniere Mar 25, 2017

OMFG!!

Raymond's script Snap stretch marker under mouse to closest grid line works again!!!!
I'm so happy!! 😄 😄 😅

daxliniere commented Mar 25, 2017

OMFG!!

Raymond's script Snap stretch marker under mouse to closest grid line works again!!!!
I'm so happy!! 😄 😄 😅

@X-Raym

This comment has been minimized.

Show comment
Hide comment
@X-Raym

X-Raym Mar 25, 2017

@daxliniere At last 🎉 👍
@swstim Thanks 📦
Closed because fix here : dbae5b9 (for v2.9.1)

X-Raym commented Mar 25, 2017

@daxliniere At last 🎉 👍
@swstim Thanks 📦
Closed because fix here : dbae5b9 (for v2.9.1)

@X-Raym X-Raym closed this Mar 25, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment