New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default ReaConsole shortcut doesn't work #877

Closed
andybarilla opened this Issue Jul 6, 2017 · 5 comments

Comments

Projects
None yet
3 participants
@andybarilla

andybarilla commented Jul 6, 2017

I've tried this on two difference machines (both Windows) with both a regular installation and portable.

If I check the keyboard shortcut for ReaConsole and it says 'C' but that doesn't work. If I remove that and re-set it to 'C' it works fine.

Before fixing it once I tried assigning 'C' to another random command and it didn't warn me about the shortcut already being used.

@nofishonfriday

This comment has been minimized.

Show comment
Hide comment
@nofishonfriday

nofishonfriday Sep 7, 2017

Collaborator

Confirmed here (on Windows).

Collaborator

nofishonfriday commented Sep 7, 2017

Confirmed here (on Windows).

@cfillion

This comment has been minimized.

Show comment
Hide comment
@cfillion

cfillion Sep 7, 2017

Collaborator

It works on macOS. Setting the FVIRTKEY flag in the fVirt member of the action's ACCEL struct fixes it on both Linux and Windows.

EDIT: Commit a1507f7 broke that shortcut on Windows while fixing it on macOS (but not Linux).

Collaborator

cfillion commented Sep 7, 2017

It works on macOS. Setting the FVIRTKEY flag in the fVirt member of the action's ACCEL struct fixes it on both Linux and Windows.

EDIT: Commit a1507f7 broke that shortcut on Windows while fixing it on macOS (but not Linux).

cfillion added a commit to cfillion/sws that referenced this issue Sep 7, 2017

@nofishonfriday

This comment has been minimized.

Show comment
Hide comment
@nofishonfriday

nofishonfriday Sep 8, 2017

Collaborator

Thanks for the fix @cfillion .

Just a thought, I (and I assume some other users) have currently assigned "C" to some other action. Wouldn't this lead to a potential conflict now if "C" gets re-assigned also as default shortcut for the console (as Reaper doesn't allow same shortcut for different actions, what will happen ?)

Collaborator

nofishonfriday commented Sep 8, 2017

Thanks for the fix @cfillion .

Just a thought, I (and I assume some other users) have currently assigned "C" to some other action. Wouldn't this lead to a potential conflict now if "C" gets re-assigned also as default shortcut for the console (as Reaper doesn't allow same shortcut for different actions, what will happen ?)

@cfillion

This comment has been minimized.

Show comment
Hide comment
@cfillion

cfillion Sep 8, 2017

Collaborator

From my tests, REAPER ignores the shortcut suggested by extensions if the key was set on another action before (even if the shortcut was removed since and the key is now unused).

Collaborator

cfillion commented Sep 8, 2017

From my tests, REAPER ignores the shortcut suggested by extensions if the key was set on another action before (even if the shortcut was removed since and the key is now unused).

@nofishonfriday

This comment has been minimized.

Show comment
Hide comment
@nofishonfriday

nofishonfriday Sep 9, 2017

Collaborator

So it seems fine I think, thanks for testing.

Collaborator

nofishonfriday commented Sep 9, 2017

So it seems fine I think, thanks for testing.

@swstim swstim closed this in d24b333 Sep 28, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment