Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crossfade adjacent selected items (move later items) #902

Open
cjunekim opened this issue Oct 5, 2017 · 6 comments
Open

Crossfade adjacent selected items (move later items) #902

cjunekim opened this issue Oct 5, 2017 · 6 comments

Comments

@cjunekim
Copy link

@cjunekim cjunekim commented Oct 5, 2017

Hello

Does it actually move the later items? I have experimented that action with various timing and I could not find any movement in the items.

In what situations does the action move items?

@veto-gh
Copy link

@veto-gh veto-gh commented Oct 9, 2017

I actually can't see anything which indicates any moving of later items too:
https://github.com/reaper-oss/sws/blob/master/Misc/ItemParams.cpp#L412

The author was probably referring to the code, which basically increases the length of the second item of any adjacent item pair to item length + default fade lenght/2 and moves it to item start - default fade lenght/2, which (concerning the item position) is the same as dragging the left item edge to the left.

Maybe the action should be reworded "SWS: Crossfade adjacent selected items (move edges of adjacent items)" ?

@nofishonfriday
Copy link
Collaborator

@nofishonfriday nofishonfriday commented Oct 9, 2017

Agreed, renaming would make sense here but I'm a little hesitant with renaming SWS actions for not breaking existing custom actions.

Not sure what's the better alternative here.
Maybe wait for Tim's thoughts ?

edit:
Wait, SWS actions get identified in custom actions by their ID, not by their actual name or ?
So it shouldn't be a problem then.

@wolqws
Copy link
Contributor

@wolqws wolqws commented Oct 9, 2017

IDs uniquely identify actions and should not change, changing their name is ok.

@veto-gh
Copy link

@veto-gh veto-gh commented Oct 9, 2017

Thanks nofish and wol. Yes the action is referenced by _SWS_CROSSFADE. A concern would be users trying to find the action by filtering its name but that is moot because imo nobody will filter by the "move later items" part.

nofishonfriday added a commit to nofishonfriday/sws that referenced this issue Oct 14, 2017
…ssfade adjacent selected items (move edges of adjacent items)' reaper-oss#902
@nofishonfriday
Copy link
Collaborator

@nofishonfriday nofishonfriday commented Oct 14, 2017

Since nobody seems to be against it, I've renamed the action.
Hope that's ok.

nofishonfriday added a commit to nofishonfriday/sws that referenced this issue Oct 14, 2017
…ssfade adjacent selected items (move edges of adjacent items)" reaper-oss#902
@veto-gh
Copy link

@veto-gh veto-gh commented Oct 17, 2017

Thanks Nofish!

nofishonfriday added a commit to nofishonfriday/sws that referenced this issue Nov 16, 2017
…ssfade adjacent selected items (move edges of adjacent items)" reaper-oss#902
nofishonfriday added a commit to nofishonfriday/sws that referenced this issue Dec 3, 2017
…ssfade adjacent selected items (move edges of adjacent items)" reaper-oss#902
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants