New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make component-prefix mandatory in layout code #55

Closed
dagwieers opened this Issue Apr 5, 2012 · 3 comments

Comments

Projects
None yet
2 participants
@dagwieers
Copy link
Member

dagwieers commented Apr 5, 2012

Currently the EXCLUDE_* variables only require a component-prefix in those cases where it is ambiguous. By requiring all components to be prefixed, we remove the inconsistency from the syntax.So instead of /dev/vg_data, it would become vg:vg_data

Example:

EXCLUDE_BACKUP=( "fs:/data" )
EXCLUDE_RECREATE=( "vg:vg_san" )
EXCLUDE_RESTORE=( "fs:/tmp" )

PS This affects #54

@dagwieers dagwieers referenced this issue Aug 24, 2012

Closed

mkbackup fails #25

@gdha

This comment has been minimized.

Copy link
Member

gdha commented Oct 2, 2013

@jhoekx as far I can see in the current code "fs:/mnt-point" is already being processed by the exclude code parts:
./layout/prepare/default/61_exclude_from_restore.sh, ./layout/save/default/34_generate_mountpoint_device.sh

However, I couldn't find a link to "vg:vg_san" (guessing in ./layout/save/default/31_include_exclude.sh)
Am I missing something? Or can we close this issue?

@gdha gdha removed this from the Rear v1.17 milestone Jan 4, 2015

@gdha

This comment has been minimized.

Copy link
Member

gdha commented Aug 10, 2015

@dagwieers @jhoekx Do you still see the need of this request, or can we close it?

@gdha

This comment has been minimized.

Copy link
Member

gdha commented Feb 5, 2016

Re-open this issue when we found a sponsor to implement this missing feature

@gdha gdha closed this Feb 5, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment