Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace AUTHORS by MAINTAINERS file and explain more background info #1429

Merged
merged 7 commits into from Sep 24, 2017

Conversation

@schlomo
Copy link
Member

commented Jul 24, 2017

about the many contributors who helped ReaR. Fixes #1427

For minor changes please simply push to this branch. For bigger ones let me know and I'll do the work.

I'll ask everybody to review. If I don't hear from you within a couple of days/weeks then I assume that you consent to this change.

@schlomo schlomo added this to the ReaR v2.3 milestone Jul 24, 2017

@schlomo schlomo self-assigned this Jul 24, 2017

@schlomo schlomo requested review from dagwieers, jhoekx, gdha, jsmeix and gozora Jul 24, 2017

@jsmeix jsmeix referenced this pull request Jul 25, 2017

Closed

Generate AUTHORS file #1428

@jsmeix

jsmeix approved these changes Jul 25, 2017

Copy link
Member

left a comment

Looks perfectly fine from my point of view.
It is at least a major cleanup and improvement of what it was before.

@jsmeix

This comment has been minimized.

Copy link
Member

commented Jul 25, 2017

I wonder if it is legally (i.e. according to the GPL)
sufficient to have the authors and contributors
(I think in GPL wording all relevant contributors
are legally same as authors) only mentioned indirectly
via an external link as in

To see the full list of authors and their contributions please look at
https://github.com/rear/rear/graphs/contributors

Perhaps we must provide a list of the authors in a source file?
Perhaps we can leave out the e-mail addresses of the authors?

Or does a git repository count as sources for the GPL?
I.e. what one gets via

git clone https://github.com/rear/rear.git

because that contains all authors and their contributions
in the git log - but a special tool 'git' is needed here
to "pull out" the authors and their contributions.

@schlomo

This comment has been minimized.

Copy link
Member Author

commented Jul 25, 2017

@jsmeix I share your concern. It seems that the FSF serves as some kind of a copyright proxy (https://www.gnu.org/prep/maintain/html_node/Copyright-Papers.html), but the process seems quite cumbersome on first reading. Can you maybe ask the specialists at SUSE for some practical advise?

@jsmeix

This comment has been minimized.

Copy link
Member

commented Jul 25, 2017

@schlomo
I will ask them but from my (outsider) experience
often a lawyer cannot provide concrete practical advise
because (as far as I understand it) license issues are
often complicated without matching court decisions
so that often "it depends..."

@jsmeix

This comment has been minimized.

Copy link
Member

commented Jul 26, 2017

The currently proposed MAINTAINERS file
https://github.com/rear/rear/blob/93e544a258ff184d09b94a5c7128380a488b3227/MAINTAINERS
lists Dag Wieers and Jeroen Hoekx
but as far as I see they do no longer actively maintain ReaR.

I think the MAINTAINERS file is meant to list
those who currently actively maintain ReaR.

I think a MAINTAINERS file is not meant to list all
contributors which is what an AUTHORS file is meant to do.

Accordingly I think when Dag Wieers and Jeroen Hoekx
really do no longer actively maintain ReaR, then they
should no longer be not listed in the MAINTAINERS file.

Alternatively the MAINTAINERS file could have separated
sections to distinguish currently active maintainers
from no longer active maintainers.

E.g. something as the "Alumni" section in the exhaustive and explanatory
https://raw.githubusercontent.com/moby/moby/master/MAINTAINERS
but probably much shorter for what ReaR actually needs.

@schlomo

This comment has been minimized.

Copy link
Member Author

commented Jul 26, 2017

I'll ask them

schlomo added some commits Jul 24, 2017

Replace AUTHORS by MAINTAINERS file and explain more background info
about the many contributors who helped ReaR. Fixes #1427
Fix asciidoc links
Sorry, my stupid. Should have checked the cheat sheet and not assume markdown syntax

@schlomo schlomo force-pushed the introduce-maintainers-file branch from 93e544a to 3c000d7 Jul 27, 2017

@gdha

gdha approved these changes Aug 23, 2017

@dagwieers
Copy link
Member

left a comment

I don't really have an opinion on this.
I am fine with whatever you guys decide :-)

I wish I had more time to spend on ReaR though.

@dagwieers

This comment has been minimized.

Copy link
Member

commented Aug 23, 2017

BTW I noticed that I still have merge rights on this repository. This probably dates back from the time we moved to Github. (Which I think was the best decision we could have made ;-))

You may want to restrict my "write" access (and probably @jhoekx too) for security purposes. It would still be nice to stay as a member of the project though.

And when there is a need to have commit/merge rights again, I'm sure we can enable it again at that time.

@schlomo schlomo force-pushed the introduce-maintainers-file branch from 00125f9 to 3c000d7 Sep 24, 2017

@schlomo schlomo force-pushed the introduce-maintainers-file branch from 3e45d35 to 8f2a16c Sep 24, 2017

@schlomo schlomo closed this Sep 24, 2017

@schlomo schlomo reopened this Sep 24, 2017

@schlomo schlomo merged commit 74787aa into master Sep 24, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@schlomo

This comment has been minimized.

Copy link
Member Author

commented Sep 24, 2017

@jsmeix I know that this is not perfect, I hope that this is a step into the right direction.

@schlomo schlomo deleted the introduce-maintainers-file branch Sep 24, 2017

@jsmeix

This comment has been minimized.

Copy link
Member

commented Sep 25, 2017

@schlomo
for me it is "sufficiently perfect" 👍 cf.
#1429 (review)
Many thanks for it!

gdha added a commit that referenced this pull request Oct 2, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.