Migrate XFS configuration files.

[gozora]

• Type: Bug Fix / Enhancement

• Impact: Normal

• Reference to related issue (URL): Mapping disks doesn't map corresponding XFS information file #2333

• How was this pull request tested?
  Successfully restored VM with following disk layout from VirtualBox to Qemu. (migration from /dev/sd* to /dev/vd*)

# lsblk -ipo NAME,KNAME,PKNAME,TRAN,TYPE,FSTYPE,SIZE,MOUNTPOINT
NAME                        KNAME     PKNAME    TRAN   TYPE  FSTYPE             SIZE MOUNTPOINT
/dev/sda                    /dev/sda            sata   disk                       8G 
|-/dev/sda1                 /dev/sda1 /dev/sda         part  vfat               200M /boot/efi
|-/dev/sda2                 /dev/sda2 /dev/sda         part  xfs                  1G /boot
`-/dev/sda3                 /dev/sda3 /dev/sda         part  LVM2_member        6.8G 
  |-/dev/mapper/centos-root /dev/dm-0 /dev/sda3        lvm   xfs                  6G /
  `-/dev/mapper/centos-swap /dev/dm-1 /dev/sda3        lvm   swap               820M [SWAP]
/dev/sdb                    /dev/sdb            sata   disk  mpath_member         8G 
`-/dev/mapper/disk_2        /dev/dm-3 /dev/sdb         mpath linux_raid_member    8G 
  `-/dev/md0                /dev/md0  /dev/dm-3        raid1 xfs                  8G /data
/dev/sdc                    /dev/sdc            sata   disk  mpath_member         8G 
`-/dev/mapper/disk_1        /dev/dm-2 /dev/sdc         mpath linux_raid_member    8G 
  `-/dev/md0                /dev/md0  /dev/dm-2        raid1 xfs                  8G /data
/dev/sr0                    /dev/sr0            ata    rom                     1024M 

• Brief description of the changes in this pull request:
  When in MIGRATION_MODE, migrate/rename XFS configuration files so they follow disk mapping set by user.

[jsmeix]

@gozora
please have a look at my
#2431 (comment)
and
#2431 (comment)

Perhaps I am wrong but at least from plain looking at the code
it seems things could go wrong as I described.
If all is OK perhaps a comment that explains how those sed substitutions
behave fail-safe could help to better understand how things actually work.

[gozora]

Hello @jsmeix,

Thanks for your comments!
I've made some improvements in code which should cover also problem when mapping multipath device to ordinary disk. Which previously created entry like meta-data=/dev/mapper/sdd.

V.

[jsmeix]

I don't know the XFS configuration file syntax
so I cannot actually verify the sed substitute commands to
"Replace old device name in meta-data= option in XFS configuration file"
but because @gozora you now double-checked that part
I trust that now things work sufficiently well.

[jsmeix]

@gozora
since we are currently in early ReaR 2.7 development mode
I think you could "just merge" it e.g. tomorrow
provided @gdha does not object until then?

[jsmeix]

... or "just merge" it right now ;-)

[gozora]

Thanks for your reviews!

V.