New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In-memory version of data stores #135

Merged
merged 53 commits into from Oct 10, 2016

Conversation

Projects
None yet
3 participants
@tehmou
Collaborator

tehmou commented Jun 27, 2016

  • Based on pull request #133
  • Add appbasic for the same functionality (without widget) having all the stores in memory
  • Works but needs a bit of cleaning up with duplicated code
  • In-memory stores can probably be moved into the public library

@tehmou tehmou changed the title from [WIP] Feature/basic example to Feature/basic example Oct 4, 2016

Show outdated Hide outdated ...ava/io/reark/rxgithubapp/advanced/data/stores/GitHubRepositoryStore.java
public ApplicationTest() {
super(Application.class);
}
}

This comment has been minimized.

@tomaszpolanski

tomaszpolanski Oct 4, 2016

Collaborator

End line

@tomaszpolanski

tomaszpolanski Oct 4, 2016

Collaborator

End line

This comment has been minimized.

@tehmou

tehmou Oct 4, 2016

Collaborator

Added

@tehmou

tehmou Oct 4, 2016

Collaborator

Added

@Override
public void onPause() {
super.onPause();
repositoriesViewBinder.unbind();

This comment has been minimized.

@tomaszpolanski

tomaszpolanski Oct 4, 2016

Collaborator

Shouldn't unbind be before onPause?

@tomaszpolanski

tomaszpolanski Oct 4, 2016

Collaborator

Shouldn't unbind be before onPause?

This comment has been minimized.

@tehmou

tehmou Oct 4, 2016

Collaborator

super.onPause() does not trigger the pausing, afaik onPause is just a callback to be executed entirely before the pausing happens.

@tehmou

tehmou Oct 4, 2016

Collaborator

super.onPause() does not trigger the pausing, afaik onPause is just a callback to be executed entirely before the pausing happens.

Show outdated Hide outdated ...ava/io/reark/rxgithubapp/advanced/data/stores/GitHubRepositoryStore.java
public GsonStoreCoreBase(@NonNull ContentResolver contentResolver, @NonNull Gson gson) {
super(contentResolver);
Preconditions.checkNotNull(gson, "Gson cannot be null.");

This comment has been minimized.

@tomaszpolanski

tomaszpolanski Oct 4, 2016

Collaborator

Is there a special reason why would you use it like this: this.gson = Preconditions.checkNotNull(gson, "Gson cannot be null.");?

@tomaszpolanski

tomaszpolanski Oct 4, 2016

Collaborator

Is there a special reason why would you use it like this: this.gson = Preconditions.checkNotNull(gson, "Gson cannot be null.");?

This comment has been minimized.

@apoi

apoi Oct 6, 2016

Collaborator

Perhaps I'll clean up these null checks in a separate PR.

@apoi

apoi Oct 6, 2016

Collaborator

Perhaps I'll clean up these null checks in a separate PR.

<activity android:name=".activities.ChooseRepositoryActivity" />
</application>
</manifest>

This comment has been minimized.

@tomaszpolanski

tomaszpolanski Oct 4, 2016

Collaborator

End line

@tomaszpolanski

tomaszpolanski Oct 4, 2016

Collaborator

End line

Show outdated Hide outdated appbasic/src/main/java/io/reark/rxgithubapp/basic/data/DataLayer.java
Show outdated Hide outdated appbasic/src/main/java/io/reark/rxgithubapp/basic/data/DataStoreModule.java
Show outdated Hide outdated ...main/java/io/reark/reark/data/stores/cores/ContentProviderStoreCore.java
Show outdated Hide outdated reark/src/main/java/io/reark/reark/data/stores/cores/MemoryStoreCore.java
Show outdated Hide outdated reark/src/main/java/io/reark/reark/data/stores/cores/MemoryStoreCore.java
Show outdated Hide outdated reark/src/main/java/io/reark/reark/data/stores/cores/MemoryStoreCore.java
Show outdated Hide outdated reark/src/main/java/io/reark/reark/data/utils/DataLayerUtils.java

@apoi apoi changed the title from Feature/basic example to In-memory version of data stores Oct 6, 2016

Merge pull request #142 from reark/task/basic-example-fixes
Review fixes to in-memory stores PR

@apoi apoi merged commit 46a8246 into master Oct 10, 2016

@apoi apoi deleted the feature/basic-example branch Oct 10, 2016

bifri pushed a commit to bifri/reark that referenced this pull request Oct 11, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment