Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed bug where default label was not being used in reading ease notifier disco plugin #282

Open
wants to merge 1 commit into
base: carleton-4.8.1
from

Conversation

Projects
None yet
1 participant
@natepixel
Copy link
Collaborator

commented Apr 28, 2019

Simple bug fix - in instances that use carleton-4.8.1 code the reading ease notifier disco plugin looks kind of funky out of the box because the label is missing. The code is intended to show some default text there that is contained in $label but instead there is a reference to a setting REASON_READING_EASE_LABEL hard-coded that will be missing in most instances and isn't referenced in the upgrade file. The little fix uses $label (which as the value of REASON_READING_EASE_LABEL OR some default text).

@natepixel natepixel requested a review from mryand Apr 28, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.