Subscribe to more #91
Conversation
|
Hey there! Sorry about the delay, I was in vacation these past 2 weeks. |
examples/persons/src/Client.re
Outdated
| (), | ||
| ); | ||
|
|
||
| /* based on test, execute left or right */ |
There was a problem hiding this comment.
left or right you mean the ternary logic?
There was a problem hiding this comment.
My guess it was copypasted from reason-apollo examples, not sure what it means 😄
I've replaced it with the comment about link splitting from the official apollo docs.
Yakimych
force-pushed
the
subscribe-to-more
branch
from
896a9cf
to
8079118
Compare
|
@fakenickels No worries - thanks for reviewing. I've rebased the branch on master and resolved the conflicts. Nice to see that |
| ) { | ||
| | (Some(prev), Some(newData)) => | ||
| { | ||
| ...prev, // NOTE: This only works with BuckleScript 7 |
There was a problem hiding this comment.
it's a good demo of functionality with BS7!
| ]; | ||
|
|
||
| // Defining those types and "%identity" converters below allows us to | ||
| // write the updateQuery in pure Reason and avoid bs.raw alltogether |
There was a problem hiding this comment.
maybe worths mentioning that we need to write these types by hand because we can't use right away those from graphql_ppx_re to not make people confused
gonna link this discussion
|
@all-contributors update @Yakimych to add code |
|
I've put up a pull request to add @code! 🎉 |
|
@all-contributors update @Yakimych for code |
|
I could not determine your intention. Basic usage: @all-contributors please add @Someone for code, doc and infra For other usages see the documentation |
|
@all-contributors add @Yakimych for code, bugs |
|
I've put up a pull request to add @Yakimych! 🎉 |
|
As we are upgrading to BS7 I released this under a major version, now it is available as v5.0.0. Thanks a lot @Yakimych ! |
|
We had updated the lib itself but not the demo as you had noticed 🤔 |
This PR is a continuation of the work done by @MargaretKrutikova on subscribeToMore. I've added examples to demonstrate the functionality and rearranged the code a bit. I am also planning to add more examples after migrating from Graphcool to Hasura: #90
There are a few questions I am not sure about: