Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebView Js.nullable instead of option #151

Closed
maarekj opened this issue Feb 26, 2018 · 4 comments

Comments

Projects
3 participants
@maarekj
Copy link
Contributor

commented Feb 26, 2018

It seems to me that in WebView.rei, we should change option(t) to Js.nullable(t)

~onNavigationStateChange: {
  .
  "url": option(string),
  "title": option(string),
  "loading": option(bool),
  "canGoBack": option(bool),
  "canGoForward": option(bool)
} => unit

to

~onNavigationStateChange: {
  .
  "url": Js.nullable(string),
  "title": Js.nullable(string),
  "loading": Js.nullable(bool),
  "canGoBack": Js.nullable(bool),
  "canGoForward": Js.nullable(bool)
} => unit

Indeed no conversion is done in WebView.re

@grabbou

This comment has been minimized.

Copy link
Collaborator

commented Sep 19, 2018

FYI: WebView is going to be removed from React Native soon anyway (already being extracted).

@maarekj

This comment has been minimized.

Copy link
Contributor Author

commented Sep 20, 2018

@grabbou 😲What will WebView be replaced by?

@grabbou

This comment has been minimized.

Copy link
Collaborator

commented Sep 20, 2018

Nothing :) It's going to be in a separate package as we are working on making the core even smaller. You can follow updates here: react-native-community/discussions-and-proposals#3

@MoOx

This comment has been minimized.

Copy link
Member

commented Apr 13, 2019

WebView as ben removed & won't be in the upcoming rewrite.

@MoOx MoOx closed this Apr 13, 2019

Roadmap automation moved this from backlog to done Apr 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.